Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default colours no longer show #7041

Closed
maddisondesigns opened this issue May 31, 2018 · 7 comments
Closed

Default colours no longer show #7041

maddisondesigns opened this issue May 31, 2018 · 7 comments
Labels
[Status] Needs More Info Follow-up required in order to be actionable.

Comments

@maddisondesigns
Copy link

Describe the bug
In my theme I've added support for wide and full images using add_theme_support( 'align-wide' );. I haven't specified any colours though.

When I click on a Paragraph block and go to select a Background or Text colour, I'm not given any default colours. It simply shows 4 empty colour selectors.

To Reproduce
Steps to reproduce the behavior:

  1. Insert Paragraph Block
  2. Click on Paragraph Block
  3. Click on 'Block' tab in sidebar
  4. Click on 'Background Color' or 'Text Color' and try to select a default colour

Expected behavior
Gutenberg used to provide a default selection of colours. If this is no longer the case, then those blank colour selectors should be removed as they serve no purpose.

Screenshots
gutenberg_nodefaultcolours

macOS 10.12.1 (16B2659)
Firefox Quantum 60.0.1 (64-bit)
Gutenberg 2.9.2

@nfmohit
Copy link
Member

nfmohit commented May 31, 2018

I'm not able to reproduce the issue on my end, the default colors show up as expected for me:

issue-7041

macOS 10.13.4
Firefox Quantum 60.0.1 (64-bit)
Gutenberg 2.9.2

@maddisondesigns
Copy link
Author

I've deactivated every plugin (except for Gutenberg) and switched the theme to the Gutenberg theme, and I still see a similar thing. I say similar because the blank colour selectors are now just block dots rather than black rings.

gutenberg_nodefaultcolours2

There doesn't appear to be any errors when I look at the console (just a warning about using the gutenberg array being deprecated, in the Gutenberg theme)

If I switch to TwentySeventeen, which doesn't add support for Gutenberg, then the default colours show.

Based on this very quick test, I would guess that the colours are being messed up when 'add_theme_support` is being used.

@Netzberufler
Copy link

The implementation for the editor color palette feature changed recently and now works with CSS classes and named color arrays.
#6585

Make sure you don't have the old implementation anywhere in your theme, and also add the new custom color classes to your theme's stylesheet.

@maddisondesigns
Copy link
Author

@Netzberufler As mentioned in my initial comment, I didn't define any colours, which should mean that Gutenberg shows it's default colours.

@danielbachhuber danielbachhuber added the [Status] Needs More Info Follow-up required in order to be actionable. label Jun 4, 2018
@danielbachhuber
Copy link
Member

I'm unable to reproduce this with Twenty Seventeen active.

I've deactivated every plugin (except for Gutenberg) and switched the theme to the Gutenberg theme, and I still see a similar thing.

Which "Gutenberg theme" are you referring to? Maybe this is what needs to be updated?

@maddisondesigns
Copy link
Author

Which "Gutenberg theme" are you referring to? Maybe this is what needs to be updated?

This was the Gutenberg theme I was referring to:
https://github.com/WordPress/gutenberg-starter-theme

I know this theme is quite out of date now but I tried it simply because it's got very minimal styling.

I originally encountered the issue when using a theme I developed myself, which is up to date with Gutenberg changes.

I've just updated to Gutenberg 3.0.0 and the default colours are showing again now, when using my own them and the Gutenberg theme.

@danielbachhuber
Copy link
Member

Thanks for the update, @maddisondesigns. Glad you were able to sort it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs More Info Follow-up required in order to be actionable.
Projects
None yet
Development

No branches or pull requests

4 participants