Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for the keyboard shortcuts in tooltips #6669

Closed
afercia opened this issue May 9, 2018 · 4 comments
Closed

Improvements for the keyboard shortcuts in tooltips #6669

afercia opened this issue May 9, 2018 · 4 comments
Labels
[Type] Enhancement A suggestion for improvement.

Comments

@afercia
Copy link
Contributor

afercia commented May 9, 2018

The new keyboard shortcuts shown in the tooltips of the top toolbar buttons (see #6605) are a good idea to expose the available shortcuts. Tooltips usually open at the top of the related controls:

screen shot 2018-05-09 at 23 51 39

Now, when quickly hovering on these buttons (e.g. from Add block to Undo / Redo) or when navigating with the keyboard, the "jump effect" of the tooltip that sometimes opens at the top, sometimes at the bottom, is a bit confusing and distracting.

screen shot 2018-05-09 at 23 51 41

When the shortcut text is longer than the tooltip text, the latter is misaligned (should be centered?):

screen shot 2018-05-10 at 00 25 43

When a tooltip shows just the shortcut (because the button already has visible text and doesn't need a tooltip to expose its name) then it's a bit difficult to see. To me, a tooltip that shows just ⌘S doesn't look so right, but maybe it's just me.

screen shot 2018-05-10 at 00 26 13

I'd recommend to consider some improvements and try to always open the tooltips in the same direction. That would probably require to make their height a bit smaller, or put the suggested keyboard shortcut on the same line, or some other adjustment.

@afercia afercia added the Needs Design Feedback Needs general design feedback. label May 9, 2018
@karmatosed
Copy link
Member

When a tooltip shows just the shortcut (because the button already has visible text and doesn't need a tooltip to expose its name) then it's a bit difficult to see. To me, a tooltip that shows just ⌘S doesn't look so right, but maybe it's just me.

I think that's fine as we don't need to repeat what is already said.

I'd recommend to consider some improvements and try to always open the tooltips in the same direction.

I think that's sensible as an approach otherwise it is super disorientating.

@youknowriad
Copy link
Contributor

Is this still valid? It seems like they all show up under the buttons right now?

@karmatosed
Copy link
Member

@afercia could you confirm if this is still something to resolve as I agree with @youknowriad that I can't find it still being an issue. If it is, could we have some examples please?

@afercia
Copy link
Contributor Author

afercia commented Feb 25, 2019

Fixed in #11307 see #11180 (which actually was a duplicate of this issue).

@afercia afercia closed this as completed Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants