-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements for the keyboard shortcuts in tooltips #6669
Comments
I think that's fine as we don't need to repeat what is already said.
I think that's sensible as an approach otherwise it is super disorientating. |
Is this still valid? It seems like they all show up under the buttons right now? |
@afercia could you confirm if this is still something to resolve as I agree with @youknowriad that I can't find it still being an issue. If it is, could we have some examples please? |
The new keyboard shortcuts shown in the tooltips of the top toolbar buttons (see #6605) are a good idea to expose the available shortcuts. Tooltips usually open at the top of the related controls:
Now, when quickly hovering on these buttons (e.g. from Add block to Undo / Redo) or when navigating with the keyboard, the "jump effect" of the tooltip that sometimes opens at the top, sometimes at the bottom, is a bit confusing and distracting.
When the shortcut text is longer than the tooltip text, the latter is misaligned (should be centered?):
When a tooltip shows just the shortcut (because the button already has visible text and doesn't need a tooltip to expose its name) then it's a bit difficult to see. To me, a tooltip that shows just
⌘S
doesn't look so right, but maybe it's just me.I'd recommend to consider some improvements and try to always open the tooltips in the same direction. That would probably require to make their height a bit smaller, or put the suggested keyboard shortcut on the same line, or some other adjustment.
The text was updated successfully, but these errors were encountered: