Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the speak messages when switching editor modes #65873

Closed
2 tasks done
afercia opened this issue Oct 4, 2024 · 5 comments · Fixed by #66278
Closed
2 tasks done

Update the speak messages when switching editor modes #65873

afercia opened this issue Oct 4, 2024 · 5 comments · Fixed by #66278
Assignees
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Status] In Progress Tracking issues with work in progress [Type] Regression Related to a regression in the latest release

Comments

@afercia
Copy link
Contributor

afercia commented Oct 4, 2024

Description

#65204 removes 'select' mode (also called 'navigation' mode). Following changes renamed the editor modes to 'Write' and 'Design'.

However, the speak message for screen reader users still refer to 'edit' and 'navigation' and still mention the Enter and Escape key to switch modes, which are no longer funcitonal.

These messages must be updated and simplified.

Cc @WordPress/gutenberg-core

if ( mode === 'navigation' ) {
speak(
__(
'You are currently in navigation mode. Navigate blocks using the Tab key and Arrow keys. Use Left and Right Arrow keys to move between nesting levels. To exit navigation mode and edit the selected block, press Enter.'
)
);
} else if ( mode === 'edit' ) {
speak(
__(
'You are currently in edit mode. To return to the navigation mode, press Escape.'
)
);

Step-by-step reproduction instructions

N/A

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes
@afercia afercia added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Regression Related to a regression in the latest release labels Oct 4, 2024
@getdave getdave moved this to 📥 Todo in WordPress 6.7 Editor Tasks Oct 4, 2024
@youknowriad
Copy link
Contributor

I removed this from 5.7 tasks because AFAIK, this mode change is not landing in 6.7

@afercia
Copy link
Contributor Author

afercia commented Oct 4, 2024

Oh I see #65204 is in the 19.4 and WordPress will include the plugin up to 19.3? Is that correct?

@youknowriad
Copy link
Contributor

Yes, that's correct.

@PARTHVATALIYA
Copy link
Contributor

PARTHVATALIYA commented Oct 4, 2024

I suggest the following updates to the screen reader messages to reflect the new mode names and provide accurate instructions for users. Here's the updated message logic:

if ( mode === 'navigation' ) {
        speak(
		__(
			'You are currently in Design mode. Use the Tab key and Arrow keys to navigate blocks.'
		)
	); 
} else if ( mode === 'edit' ) { 
	speak( 
		__( 
			'You are currently in Write mode. Navigate within the text as you normally would.'
		)
	); 
}

@afercia
Copy link
Contributor Author

afercia commented Oct 8, 2024

@PARTHVATALIYA thanks for looking into this. It's worth noting that #65204 also removed the ability to navigat ethe blocks with the Tab key. as such, while an alternative navigation mechanism ie being considered in #65603, I'd think it would be best to not mention the keyboard interaction at all and simplify the messages.

  • You are currently in Design mode
  • You are currently in Write mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Status] In Progress Tracking issues with work in progress [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants