Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught TypeError: WeakMap key Symbol() must be an object (signals.ts / interactivity) / regression Gutenberg 19.0 #64607

Closed
2 tasks done
Marc-pi opened this issue Aug 19, 2024 · 6 comments
Labels
[Feature] Interactivity API API to add frontend interactivity to blocks. [Type] Bug An existing feature does not function as intended

Comments

@Marc-pi
Copy link

Marc-pi commented Aug 19, 2024

Description

On a page that contains a cover blocks with an encapsulated Navigation block + Site Logo block, i encounter an issue on mobile : the burger menu is not clickable anymore on Safari + Firefox (ok with Chrome).

If i look at the Dev Tools, i can see a an error with this.computedsByScope.set in signals.ts (see below screenshot)
I don't know if the error explains the issue with the burger menu not anymore clickable on mobile on Safari/FF only.

Step-by-step reproduction instructions

I cannot reproduce in a test page : i've build back the banner + logo + nav, but the issue is not there.

i don't know where the interactivity API is used

  • the website uses pure standard block theme with Gutenberg
  • there is no custom code
  • as long as i can remember, i guess it is used around the site logo, but i did not investigate deepeer

the solution : if i deactivate Gutenberg 19, it works back > so the explanation is there

If someone can fix this ts error, so i can test if it fixes the issue with the nav component, would be great.

Screenshots, screen recording, code snippet

image
image
image

Environment info

  • WP 6.6.1

  • TT3 theme

  • Gutenberg 19.0.0

  • I even tested deactivating WooCommerce & WPRocket, but the issue is still there on Safari/FF mobile context (ok with Chrome).

  • Deactivating the Gutenberg plugin fixes the issue with the nav component (burger menu on mobile)

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes
@Marc-pi Marc-pi added the [Type] Bug An existing feature does not function as intended label Aug 19, 2024
@talldan talldan added the [Feature] Interactivity API API to add frontend interactivity to blocks. label Aug 20, 2024
@benharri
Copy link
Contributor

Reproducible in firefox with any block theme and gutenberg 19.0. Seems to work fine in chrome.

Uncaught TypeError: WeakMap key Symbol() must be an object
    getComputed signals.ts:111
    get state.ts:110
    ye utils.ts:388
    De store.ts:189
    De store.ts:187

The navigation overlay seems to work on other templates and I haven't been able to narrow down why.

@benharri
Copy link
Contributor

benharri commented Aug 24, 2024

Not using any cover blocks but I did put a search bar inside the navigation block. on Firefox it's broken on home but works fine on single posts. Reverted to the version bundled in core for now.

chrome seems to work perfectly fine

@matthiashonert
Copy link

I can reproduce the same on a wpcomstaging.com environment. I do not use a cover block. And the error only appears on the frontpage with firefox (mobile/desktop)

@DAreRodz
Copy link
Contributor

Hey, there's a bug fix for this in #64825. It should be fixed on the next Gutenberg release. 🙂

@Marc-pi
Copy link
Author

Marc-pi commented Aug 27, 2024

Thx !

@luisherranz
Copy link
Member

Fixed in #64825.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Interactivity API API to add frontend interactivity to blocks. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

6 participants