-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin Blocks: Consider showing source in Advanced panel #64532
Comments
yes, agreed, needed daily :-) |
I think we should be careful to force anything into that area, because that area should already be fully extensible by plugins to do with as they please. Anything we put there would potentially reduce plugin flexibility. While the benefit could be consistency, there's also an opportunity cost. By making the area free, it is a space for ideas we have perhaps not yet seen. I agree with your point, though, plugins can benefit from a great description. I wonder if there's a "best practices" doc we can add to the block card docs? |
Another reason for including it under Advanced, rather than at the top, is that most of the time this information isn't that useful to you. It's only useful when you're specifically looking for it: "I want to figure out from where this Image Compare block came, so I can share it with my friend who asked for it". |
Could something like this work, then? blockdetails.mov |
Definitely could, yes. |
From a technical standpoint, we need to consider that it may not be possible to determine which plugin a block was registered from. Registering blocks, i.e. functions like Furthermore, if the block is not exposed in the plugin directory as a plugin, we will need to find out the plugin name and author somehow. We might need to update the |
Shouldn't we reserve pills for something more important from the UX POV, like states (#38277)? They're quite prominent visually and I'd argue they're better used to inform users about the active block state, variation, or other important information rather than something that doesn't have much impact on the editing experience. |
Potentially yes. I see that as another good argument for approaching this with a systems hat on, contemplating all the information the card(s) might need to display. I'm not entirely convinced about putting this information (block source) in a menu, it feels semantically incorrect to me. |
I would recommend being extremely careful adding anything to the top block card unless we're super sure what it should be. Anything we add there pushes down the inspector controls that you'll be using 99% of the time. So we need to strike that balance where this information can still be intuitively found if you are specifically looking for it. Also just to echo/boost Aki, this may not even be possible after all:
So before we dive too deep in visual implementations (of which several of the prosals here can work), it might be good to move it to a tech spike. |
Extending the block editor through new blocks is one of the most powerful ways of adding functionality. Yet when you've installed a slew of blocks, it can be hard to know which plugin, or theme, added the particular block. Shown here, the Image Compare block from Jetpack, solely denoted using the green accent color of the icon:
Would it be useful if "block credits" were shown in the Advanced panel? Shown here, an "About" sub-section there that adds the text: "This block was added by Jetpack." with a link to the plugin page.
This would not be plugin-customizable, it would simply output the plugin-name.
@WordPress/gutenberg-design
The text was updated successfully, but these errors were encountered: