Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grid: Improve performance #63976

Open
Tracked by #57478
noisysocks opened this issue Jul 26, 2024 · 1 comment
Open
Tracked by #57478

Grid: Improve performance #63976

noisysocks opened this issue Jul 26, 2024 · 1 comment
Labels
[Feature] Layout Layout block support, its UI controls, and style output. [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@noisysocks
Copy link
Member

noisysocks commented Jul 26, 2024 •
edited
Loading

The performance of the Grid block when in Manual mode (and probably also Auto mode) is bad.

You particularly notice that the UI is slow to react to mouse events after the editor has been running for a while, so there's probably some memory leaking.

I can also see that all the components in GridVisualizer are updating on every keystroke which isn't good. An easy win might be to memo() every cell. We are probably over-useSelecting data in a lot of places too.

Kapture.2024-07-26.at.14.39.43.mp4

Let's spend some time tuning this before shipping.
@noisysocks noisysocks mentioned this issue Jul 26, 2024
Open
37 tasks
@noisysocks noisysocks changed the title Performance audit. Check component updates. We need a lot of memoization Grid: Improve performance Jul 26, 2024
@noisysocks noisysocks added [Type] Task Issues or PRs that have been broken down into an individual action to take [Feature] Layout Layout block support, its UI controls, and style output. labels Jul 26, 2024
@noisysocks
Copy link
Member Author

Sharing a that @richtabor made which shows some serious performance degradation:

cleanshot-2024-08-02-at-15.17.40.mp4

@noisysocks noisysocks mentioned this issue Aug 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Layout Layout block support, its UI controls, and style output. [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@noisysocks