Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataViews: Patterns are not bulk selectable, bulk select checkbox has "Select item: [object Object]" as its aria-label #63725

Closed
2 tasks done
talldan opened this issue Jul 19, 2024 · 3 comments · Fixed by #63733
Closed
2 tasks done

DataViews: Patterns are not bulk selectable, bulk select checkbox has "Select item: [object Object]" as its aria-label #63725

talldan opened this issue Jul 19, 2024 · 3 comments · Fixed by #63733
Assignees
@ntsekouras
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@talldan
Copy link
Contributor

talldan commented Jul 19, 2024 •
edited
Loading

Description

The inability to bulk select seems to be an issue in the gutenberg plugin.

The aria-label issue is something I can also see in WP 6.6

Step-by-step reproduction instructions

  1. Navigate to the patterns screen
  2. Go to My Patterns
  3. Observe that the bulk select checkbox is enabled, but clicking it does nothing
  4. Inspect the checkbox using the browser dev tools
  5. Observe that the aria-label is "Select item: [object Object]"

Screenshots, screen recording, code snippet

No response

Environment info

Mac OS / Brave

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes
@talldan talldan added [Type] Bug An existing feature does not function as intended [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond labels Jul 19, 2024
@ntsekouras ntsekouras mentioned this issue Jul 19, 2024
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jul 19, 2024
@ntsekouras
Copy link
Contributor

I inspected in 6.6 without GB and aria-labels seemed fine too for me. Am I missing something?

@talldan
Copy link
Contributor Author

talldan commented Jul 19, 2024

I inspected in 6.6 without GB and aria-labels seemed fine too for me. Am I missing something?

On a second check, it seems you're right. 👍

@talldan
Copy link
Contributor Author

talldan commented Jul 19, 2024

Just checked (because I definitely am not going crazy) and the aria-label was fixed by #63710. I guess it was a plugin only issue 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ntsekouras ntsekouras

Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DataViews: Fix pattens list selection WordPress/gutenberg
2 participants
@talldan @ntsekouras