-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The post title shown in the editor UI should not use the Verse block icon #62186
Comments
Perhaps |
@afercia - You mean here to change the verse icon with another icon or to remove the icon from the block? |
To me, when it's not possible to craft an icon that is meaningful and unique for its intended usage, that icon should not be used in the first place. Instead, it seems that sometimes the editor design adds icons just because the design system wants it. I'm not sure this is ideal. Personally, I'd just remove the icon. Noting that the icon has been already removed from the document bar? It is still used in the settings panel post card. Screenshot from current trunk: |
@afercia - Can I work on removing the icon from settings panel post card? Is there any where else should also be removed? |
@karthick-murugan there's no need to ask, any contributor can propose a change and submit a PR. |
The goal of any icon is to visually represent a subject matter. In the case of posts, the verse icon actually represents this better than the pin, which is commonly used to imply sticky, whether stick to the top, or CSS position: sticky. On the contrary, I would recommend we stop using the pin for posts, use this icon for posts, and design a new icon for Verse. |
Whatever the icon is, I would argue it's totally unnecessary in the post card. |
I think the fundamental problem is that the We may not be able to change the design of the verse icon itself significantly, because some developers may already be using this icon. With that in mind, I think we need new/different icons for at least these two things:
Can we discuss this issue again after we resolve the issues with these icons? |
Description
Splitting this out from #62136 (comment)
Icons should be used to uniquely identify features and controls of a user interface.
It appears that's not the case for the 'verse' icon. After recent changes to the editor top bar and the Post settings panel, the verse icon is used in association with the ppst title shown in the UI. And it is still used for the Verse block. I'm not sure that's ideal, under all aspects.
Does the Post title shown in the UI need an icon in the first place?
Screenshot:
Step-by-step reproduction instructions
Screenshots, screen recording, code snippet
No response
Environment info
No response
Please confirm that you have searched existing issues in the repo.
Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Yes
The text was updated successfully, but these errors were encountered: