Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The post title shown in the editor UI should not use the Verse block icon #62186

Open
afercia opened this issue May 31, 2024 · 11 comments
Open
Labels
Needs Design Feedback Needs general design feedback. [Package] Editor /packages/editor [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented May 31, 2024

Description

Splitting this out from #62136 (comment)

Icons should be used to uniquely identify features and controls of a user interface.

It appears that's not the case for the 'verse' icon. After recent changes to the editor top bar and the Post settings panel, the verse icon is used in association with the ppst title shown in the UI. And it is still used for the Verse block. I'm not sure that's ideal, under all aspects.

Does the Post title shown in the UI need an icon in the first place?

Screenshot:

Screenshot 2024-05-31 at 13 46 37

Step-by-step reproduction instructions

  • Create a new post.
  • Add a title and a Verse block.
  • Open the List View and the Settings pane > Post tab
  • Observe the verse icon is used in a few places to identify different features and concepts.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@afercia afercia added [Type] Bug An existing feature does not function as intended Needs Design Feedback Needs general design feedback. [Package] Editor /packages/editor labels May 31, 2024
@richtabor
Copy link
Member

Perhaps verse should have a different icon? They certainly shouldn't be the same.

@afercia
Copy link
Contributor Author

afercia commented Jun 3, 2024

Just adding that the verse icon is used also for the 'Add citation` button in the Quote block, which doesn't help with creating a cohesive visual language:

Screenshot 2024-06-03 at 10 17 01

@afercia
Copy link
Contributor Author

afercia commented Jun 3, 2024

One more usage of the verse icon is for the 'blog page' in the link suggestions:

Screenshot 2024-06-03 at 10 34 30

@afercia
Copy link
Contributor Author

afercia commented Jun 3, 2024

One more usage is in the 'Add new template' modal dialog, when the 'blog home' template is missing:

Screenshot 2024-06-03 at 11 39 10

@karthick-murugan
Copy link
Contributor

@afercia - You mean here to change the verse icon with another icon or to remove the icon from the block?

@afercia
Copy link
Contributor Author

afercia commented Dec 10, 2024

To me, when it's not possible to craft an icon that is meaningful and unique for its intended usage, that icon should not be used in the first place. Instead, it seems that sometimes the editor design adds icons just because the design system wants it. I'm not sure this is ideal. Personally, I'd just remove the icon.

Noting that the icon has been already removed from the document bar? It is still used in the settings panel post card. Screenshot from current trunk:

Image

@karthick-murugan
Copy link
Contributor

@afercia - Can I work on removing the icon from settings panel post card? Is there any where else should also be removed?

@afercia
Copy link
Contributor Author

afercia commented Dec 10, 2024

@karthick-murugan there's no need to ask, any contributor can propose a change and submit a PR.
However, I'd suggest to ask feedback from @WordPress/gutenberg-design to get to some agreement before any coding.

@jasmussen
Copy link
Contributor

jasmussen commented Dec 11, 2024

The goal of any icon is to visually represent a subject matter. In the case of posts, the verse icon actually represents this better than the pin, which is commonly used to imply sticky, whether stick to the top, or CSS position: sticky. On the contrary, I would recommend we stop using the pin for posts, use this icon for posts, and design a new icon for Verse.

@afercia
Copy link
Contributor Author

afercia commented Dec 11, 2024

Whatever the icon is, I would argue it's totally unnecessary in the post card.

@t-hamano
Copy link
Contributor

I think the fundamental problem is that the verse icon is used in other contexts and is not unique.

We may not be able to change the design of the verse icon itself significantly, because some developers may already be using this icon.

With that in mind, I think we need new/different icons for at least these two things:

  • Blog home
  • Quote block > "Add citation" button

Can we discuss this issue again after we resolve the issues with these icons?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Feedback Needs general design feedback. [Package] Editor /packages/editor [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

5 participants