Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rel="noreferrer noopener" when setting 'open in new tab' option #6186

Closed
JeroenSormani opened this issue Apr 15, 2018 · 0 comments · Fixed by #6316
Closed

Add rel="noreferrer noopener" when setting 'open in new tab' option #6186

JeroenSormani opened this issue Apr 15, 2018 · 0 comments · Fixed by #6316
Labels
[Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Type] Enhancement A suggestion for improvement.
Milestone

Comments

@JeroenSormani
Copy link

JeroenSormani commented Apr 15, 2018

Issue Overview

I noticed that the 'Open in a new tab' option has been (re-)added.
Glad to see its back, now the additional rel="noreferrer noopener" attribute should be added for security; https://www.jitbit.com/alexblog/256-targetblank---the-most-underestimated-vulnerability-ever/

It is already part of WP Core; https://core.trac.wordpress.org/ticket/36809
Has also been mentioned in the big convo here; #4583 but is yet to be implemented.

Expected Behavior

Any link that uses the 'Open in a new window' option should automatically get the rel="noreferrer noopener" attribute added too.

Current Behavior

No rel attribute is added/available.

@noisysocks noisysocks added this to the Merge Proposal: Editor milestone Apr 16, 2018
@noisysocks noisysocks added [Type] Enhancement A suggestion for improvement. [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable labels Apr 16, 2018
@mirka mirka mentioned this issue May 29, 2018
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants