It's not clear how to change URL for embed.

[Shelob9]

Issue Overview

Once I have an embed block and I want to change the URL for the block, it's not super obvious how to edit that.

If I had to guess, I would say it is the link icon in the middle of the block:

That's actually part of the UI for the embed caption, which is obvious I have a caption

Possible Solution

1. Hide the toolbar for the caption until the caption is not empty. This probably requires a placeholder or visible label for the caption so its clear you can enter a caption.
2. Add a control for embed URL to advanced settings for the block.
3. Use the pencil icon when block is focused to open a control for embed URL or focus the advanced setting for it:

Todos

• Tests
• Documentation

[danielbachhuber]

Good feedback, @Shelob9.

I've filed to WordPress 5.0 because this doesn't appear to be a blocker for merge proposal.

[karmatosed]

I think with our link UI unifications - having in toolbar - this could be solved. That said, the simpler option of a solid placeholder feels also worth exploring:

Hide the toolbar for the caption until the caption is not empty. This probably requires a placeholder or visible label for the caption so its clear you can enter a caption.

I'll flag as 'needs design' so we can iterate.

[mtias]

An edit link next to the alignment toolbar, like we have for the image block, etc, seems the consistent approach here.

[notnownikki]

Another vote for an edit link next to the alignment toolbar!

[notnownikki]

Fix is up for review in #8084

[notnownikki]

Fix merged!