-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add theme.json support for style previews for theme authors #60478
Comments
However, I hate to see this linger because of such a suggestion as I do think it is a critical piece to surfacing better theme previews. |
@colorful-tones Worth noting that my proposal is not meant to be a fallback, rather priority #1. If it does not exist, fall back to what was added in #59514. |
Indeed, I think these definitions need to be used first to gain the benefit. I think a list of |
➕ 💯 This has come up before a year or two ago on another ticket, so I'm happy to see it being resurfaced. My preview colors never look right without me rearranging my color scheme system in This also feels like some very low-hanging fruit that would improve the theme dev experience (and the user experience as a result). |
Previous discussions/attempt to automatically derive a palette in #38918 |
What about something like this? It follows the existing format of color.palette and leaves room for future example keys, say for duotone, gradients, etc. And it's similar to
Would be great if the palette values could reference slugs, or leverage variables; not hard-coded color values. |
@richtabor I would absolutely love this. |
Since #59514 is now in Gutenberg, what are the chances someone can work on implementing this, per @richtabor, so we can start testing?
|
I wasn't too familiar with |
Wanted to follow up on this issue (given work done in #61327 and otherwise): Not as terrible as my original screenshots above: And this screen only shows one as well: It would still be helpful for theme designers to choose, though. |
Yes, I completely agree with this approach. I was working on a custom theme over the weekend and was baffled by the color indicators. Providing theme authors a way to configure this manually would be a massive improvement. |
What problem does this address?
Given #59514 and the conversation in #59444, I think we should allow theme authors to use theme.json to set specific colors that would be given priority over the fallbacks (text color) and (button color/link color). With the merged PR, my Powder theme will result in this, which is less than helpful.
What is your proposed solution?
Add support in theme.json for something like this:
cc: @richtabor @justintadlock @spencerfinnell
The text was updated successfully, but these errors were encountered: