Remove incorrect dashicon and unnecessary label from the Shortcode block

[bobbingwide]

Issue Overview

This is just one of my many requirements for the Shortcode block.
It is the most easily implementable.

The shortcode block is currently displayed with a label consisting of the code-editor dashicon SVG and a text label of "Shortcode", followed by a textarea field into which the user types the shortcode / shortcodes to be expanded.

• The dashicon is the incorrect icon - the block itself uses shortcode
• The label is unnecessary - taking up a lot of space

I suggest that whole label section is removed.

Steps to Reproduce (for bugs)

1. Insert a Shortcode block.
2. Notice that the dashicon in the label shows </> where the Block's icon is [/]
3. Question the need for the text label "Shortcode"

Expected Behavior

More room to type the shortcode or shortcodes.

Current Behavior

Incorrect icon, unnecessary label.

Possible Solution

Remove the label.

Screenshots / Video

Related Issues and/or PRs

Further requirements on the shortcode block will be raised.
I have already raised #5123 and #4456.

Todos

• Tests
• Documentation

[danielbachhuber]

PR is #6033

[afercia]

I'd just like to remind that any issue/PR that touches accessibility-related things, should be marked with the related accessibility label.
For other accessibility considerations, please refer to the related PR.

[danielbachhuber]

We're not going to remove the label per #6033 (comment)

The most simple thing in this case is to keep the label. Removing it is definitely an accessibility regression compared to the previous implementation.

The block icon is now correct on the master branch: