Disable bulk actions on theme-supplied patterns

[jameskoster]

The Patterns data view currently includes patterns supplied by the active theme. These patterns can be duplicated, but not edited in any way.

Therefore it's quite confusing that the bulk actions interface (checkbox) appears attached to these items:

It's made worse by the presence of the lock icon which explicitly states: "This pattern cannot be edited.".

In such cases I think hiding the checkbox could be worth trying.

Alternatively; if bulk actions were added to theme-supplied patterns (e.g. duplicate, export), that would indirectly solve this issue.

[annezazu]

+1 to add bulk export! This has come up before (ditto with bulk import): #56794

[jorgefilipecosta]

Or is there a plan to add bulk duplication?

If not, we can hide the checkbox for theme-supplied patterns. That would eliminate the visual tension that exists between the checkbox and the lock icon:

I don't have immediate plans to add bulk duplication as that involves providing names. I will look into hiding the checkbox, the challenge here is that it is inside the data views and needs to be generic. So something generic would be don't show the check box if no bulk action can be applied to the item. I think it will work but has some performance impact. For all the items we will check against all the actions if they can be executed or not, probably not something to worry about and it is worth it.

[jameskoster]

Hmm I think this is quite problematic. Selecting an item(s) and finding that no bulk actions can be applied is a strange experience. It's made worse by the lock icon which conceptually contradicts the checkbox.

I'll update the issue to better describe the problem.

[liviopv]

I was testing the 17.8 and I found this quite confusing. I was initially in "All Patterns", and assumed bulk select would allow me to export.

If there are no plans to allow exporting theme patterns, then we should at the minimum add some context to why the Export option is unavailable when selecting a mix of user patterns and theme patterns.

[annezazu]

This PR was merged for 17.8: #58897

AFAIK this won't be backported to 6.5. As a result, I think for 6.5 we need to disable bulk actions but for the GB plugin we should continue with the bulk actions, including export. cc @jorgefilipecosta

[jameskoster]

I think for 6.5 we need to disable bulk actions

It would be a shame to lose bulk actions on user-generated patterns. If we can finish up #58950 and re-position the lock icon, hopefully we'd be in a better position to make a decision on this.