Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataViews: Improve the message when there is no results #58482

Closed
t-hamano opened this issue Jan 31, 2024 · 1 comment · Fixed by #59002
Closed

DataViews: Improve the message when there is no results #58482

t-hamano opened this issue Jan 31, 2024 · 1 comment · Fixed by #59002
Assignees
@ntsekouras
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@t-hamano
Copy link
Contributor

What problem does this address?

In the current data view, a message like this is displayed when there are no items to display.

List Layout: The message No results is displayed

image

Grid Layout: No message is displayed

image

Table Layout: The message No results is displayed

image

At the very least, some sort of message should be displayed in the grid layout as well.

What is your proposed solution?

Even in the Grid layout, the message "No results" should be displayed. Or maybe "No items found." Additionally, it might be good to provide the user with a UI to add the first item, as suggested in #54642.
@t-hamano t-hamano added [Type] Enhancement A suggestion for improvement. [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond labels Jan 31, 2024
This was referenced Jan 31, 2024
Closed
Merged
@annezazu
Copy link
Contributor

annezazu commented Feb 5, 2024

cc @mcsf for consideration!

@ntsekouras ntsekouras self-assigned this Feb 14, 2024
@ntsekouras ntsekouras mentioned this issue Feb 14, 2024
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ntsekouras ntsekouras

Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DataViews: Add loading/no results message in grid view WordPress/gutenberg
3 participants
@ntsekouras @annezazu @t-hamano