Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground toolbar pushes popover position down #58001

Closed
t-hamano opened this issue Jan 19, 2024 · 3 comments
Closed

Playground toolbar pushes popover position down #58001

t-hamano opened this issue Jan 19, 2024 · 3 comments
Labels
[Package] Components /packages/components [Type] Bug An existing feature does not function as intended

Comments

@t-hamano
Copy link
Contributor

t-hamano commented Jan 19, 2024

Note: I am currently unable to determine whether this problem should be resolved in Playground or Gutenberg.

Description

Playground injects its own toolbar at the top of the browser. Perhaps this effect pushes down the popover component, for example.

If the block toolbar is not fixed, the toolbar will cover the block, making it difficult to edit the text.

image

Additionally, the padding and margin visualizers are also pushed down.

padding-visualizer

Step-by-step reproduction instructions

  • Access https://playground.wordpress.net/.
  • After you enter text in the paragraph block, check the position of the block toolbar.
  • Check the visualizer that appears when you change the padding.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@getdave
Copy link
Contributor

getdave commented Feb 13, 2024

cc'ing @adamziel so he is aware.

@colorful-tones
Copy link
Member

colorful-tones commented Feb 14, 2024

Playground injects its own toolbar at the top of the browser. Perhaps this effect pushes down the popover component, for example.

This would seem to indicate that this is a Playground issue and should likely be reported and addressed accordingly, right? 🤔

Then we can remove this from Gutenberg.

@t-hamano
Copy link
Contributor Author

As mentioned in this comment, it might have been caused by a library that Gutenberg depends on.

I tested it again with WP6.5 Beta1 (https://playground.wordpress.net/?php=8.0&wp=beta&storage=none) and it seems that this problem does not recur, so I would like to close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Bug An existing feature does not function as intended
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants