Parent block selector button: missing focus style when 'Show button text labels' is enabled #57710
Labels
[Focus] Accessibility (a11y)
Changes that impact accessibility and need corresponding review (e.g. markup changes).
[Package] Block editor
/packages/block-editor
[Status] In Progress
Tracking issues with work in progress
[Type] Regression
Related to a regression in the latest release
Description
The Parent block selector button doesn't show a focus style when 'Show button text labels' is enabled.
Focus indication must always be clear. It appears it broke after #56335
Turns out all the buttons must use
position: relative
to allow the CSS pseudo generated element responsible for the focus style to appear and be positioned correctly. #56335 setposition: static
on this button, thus breaking the focus style.Screenshot from WordPress 6.4:
Screenshot from Gutenberg trunk:
Note: the button label is now longer, it changed in #56146
When the 'Top toolbar' is enabled, the focus style is visible. Screenshot:
Other visual glitches
Left and right padding is inconsistent compared with other buttons. Screenshot:
When 'Top toolbar' is enabled, a 'dot divider' visually separates the parent selector button from the other buttons. The dot is unevenly positioned, with both icons or text displayed. Screenshots:
Step-by-step reproduction instructions
Screenshots, screen recording, code snippet
No response
Environment info
No response
Please confirm that you have searched existing issues in the repo.
Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Yes
The text was updated successfully, but these errors were encountered: