-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image block: Confusion between the "Text over image" and "Caption" options in the Block Toolbar #56385
Comments
I think the "text over image" should be removed. It's basically transforming the block and we have a well established method for that already. |
I think the issue is valid, but I also like to think that there are careful things we can do to address this beyond just removing the button. To add a little nuance, the button was added as a nascent attempt at considering the holistic flow of wanting to build a particular layout that featured an image with a text overlay. In general, these kinds of flows — "I want to do X" and then considering carefully the whole flow to accomplish that — are flows that get increasingly important as the baseline features are starting to be there. In this case, I agree, the button is easy to confuse with caption, though to be fair it existed before the caption button. To an extent, we can think of those two buttons as doing the same; one is adding the caption as an overlay, the other as a caption below. Does the caption become a dropdown? I suspect that polishing this flow to perfection is not going to be trivial, and might involve thinking about both the Image, Cover and Group (now with background support) blocks together, and fixing a number of rough edges across those, until we get to a point where flowing between the three feels natural and intuitive. So this comment is mainly to note that we probably shouldn't just remove the "add text overlay" button as the only thing. |
I get your point, @jasmussen, but I still disagree. Here are some unordered thoughts:
|
I don't think we are in disagreement, and removing the button may in fact be part of the solution. My intent with the comment was purely to fully describe the intent of adding that button in the first place: thinking in terms of flows that make it easier for people to accomplish common layouts. This button on the Cover block exists for the same reason: It is a shortcut to making the block 100vh tall. As web-savvy folks you and I may know that we could do this by applying a 100vh height in the inspector. But any random person who doesn't know what vh units do would have no idea how to accomplish this. The button exists as a shortcut to accomlish that, and the overlay text button exists for the same reason. Where I think we agree is that those buttons may not be as intuitive at accomplishing this as they were intended to be, and it may require a rethink. That rethink may require removing such buttons, sure, what other ideas are? The use case seems valid, a person who never used the block editor wants to insert an image with a text overlay, how do they go about that? The button exists through the concept that they might intuit the Image block as a starting point, and they might not intuit that the Cover block was actually where they should've started. If you search for image in the inserter, you'll also see Cover, you might even hover the block and see an example of what you want. But in practice this hasn't been discoverable enough. |
Also, I'd personally think external captions on galleries could be nice: #56252 (comment) |
I understand, but the editor, and especially the toolbar, has evolved, and it's time to adapt. I think we should redefine what exactly the main function of the toolbar is. From what I understand by "workflows," it's a place for often-used shortcuts. Many issues assume the same, e.g., #56198, #55993, #55673, and I agree with that. This leads us to the next logical steps:
And that's how we can solve this original issue: the confusion between the "Text over Image" and "Caption" options :)
Unfortunately I do not have time to also go into this issue, but I wish that styles from Gutenberg would be as minimal as possible (aka a caption just below the image, most preferably as a separate block / div) and it's up to the theme creators how to style the captions. There are so many other options I could imagine how to handle this. Text shadows, background blur, background with opacity and/or gradient, truncating the text and opening a model on click… that's just what comes quickly into my mind. I spent so much time already reverting the styles from Gutenberg for my theme. But that's whole another discussion. |
What problem does this address?
Some users are confused about the difference between the "text over image" and "caption" icons in the Image Block Toolbar:
What is your proposed solution?
The text was updated successfully, but these errors were encountered: