Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core Data: Add TypeScript types for all the various entities #56287

Closed
swissspidy opened this issue Nov 18, 2023 · 2 comments · Fixed by #67668
Closed

Core Data: Add TypeScript types for all the various entities #56287

swissspidy opened this issue Nov 18, 2023 · 2 comments · Fixed by #67668
Assignees
@manzoorwanijk
Labels
Developer Experience Ideas about improving block and theme developer experience [Package] Core data /packages/core-data [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@swissspidy
Copy link
Member

Description

There are no TS type definitions for the post type entity, and thus no types for getPostType() et al

Step-by-step reproduction instructions

Try to use something like select( coreStore ).getPostType() in TS

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@swissspidy swissspidy added [Type] Bug An existing feature does not function as intended [Package] Core data /packages/core-data labels Nov 18, 2023
@gziolo gziolo added the Developer Experience Ideas about improving block and theme developer experience label Nov 19, 2023
@swissspidy
Copy link
Member Author

There's a Type type definition:

gutenberg/packages/core-data/src/entity-types/type.ts

Line 10 in 9088217

export interface Type< C extends Context > {

@swissspidy swissspidy changed the title Missing types for postType entity Core Data: Add TypeScript types for all the various entities Sep 11, 2024
@manzoorwanijk manzoorwanijk mentioned this issue Nov 25, 2024
Closed
@manzoorwanijk
Copy link
Member

This should be fixed by #66997

@manzoorwanijk manzoorwanijk mentioned this issue Dec 6, 2024
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manzoorwanijk manzoorwanijk

Labels
Developer Experience Ideas about improving block and theme developer experience [Package] Core data /packages/core-data [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
3 participants
@gziolo @swissspidy @manzoorwanijk