Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group block: When background image is set, has-background CSS class is missing #56261

Closed
webmandesign opened this issue Nov 17, 2023 · 2 comments · Fixed by #57495
Closed

Group block: When background image is set, has-background CSS class is missing #56261

webmandesign opened this issue Nov 17, 2023 · 2 comments · Fixed by #57495
Assignees
@andrewserong
Labels
[Block] Group Affects the Group Block Needs Testing Needs further testing to be confirmed. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@webmandesign
Copy link
Contributor

webmandesign commented Nov 17, 2023 •
edited
Loading

Description

When I set background image for Group block, I expect the has-background CSS class to be applied on the block container.
Just like it is for Cover block, for example, or when setting a background color on any block.

Step-by-step reproduction instructions

  1. Insert a Group block into post content and set a background image to it.
  2. Save post and check the results on front-end. With browser code inspector check whether the has-background class has been applied on .wp-block-group container.

Screenshots, screen recording, code snippet

group-block-background-image

Environment info

  • WordPress 6.4.1
  • Gutenberg 17.0.2

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@webmandesign webmandesign added the [Type] Bug An existing feature does not function as intended label Nov 17, 2023
@webmandesign webmandesign changed the title Group block: When background image is set, it does not apply has-background CSS class Group block: When background image is set, has-background CSS class is missing Nov 17, 2023
@jordesign jordesign added Needs Testing Needs further testing to be confirmed. [Block] Group Affects the Group Block labels Nov 19, 2023
@github-actions GitHub Actions
Copy link

Hi,
This issue has gone 30 days without any activity. This means it is time for a check-in to make sure it is still relevant. If you are still experiencing this issue with the latest versions, you can help the project by responding to confirm the problem and by providing any updated reproduction steps.
Thanks for helping out.

@github-actions github-actions bot added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Dec 20, 2023
@webmandesign
Copy link
Contributor Author

Yes, the issue still occurs on WordPress 6.4.2 with Gutenberg 17.2.3.

@github-actions github-actions bot removed the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Dec 21, 2023
@andrewserong andrewserong mentioned this issue Jan 3, 2024
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jan 3, 2024
@andrewserong andrewserong mentioned this issue Jan 7, 2024
Open
69 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewserong andrewserong

Labels
[Block] Group Affects the Group Block Needs Testing Needs further testing to be confirmed. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Background image: Add has-background classname when background image is applied WordPress/gutenberg
3 participants
@jordesign @webmandesign @andrewserong