Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor <BlockTools /> to be exported with all Block Toolbar Functionality #56046

Closed
jeryj opened this issue Nov 10, 2023 · 1 comment
Closed
Labels
[Feature] Blocks Overall functionality of blocks [Type] Enhancement A suggestion for improvement.

Comments

@jeryj
Copy link
Contributor

jeryj commented Nov 10, 2023

Follow-up to #55787

What problem does this address?

The <BlockToolbar /> component should be able to be used directly with all of the functionality of the Block Toolbar. In its currents state, the <BlockToolbar /> component does not have many of the accessibility improvements and keyboard navigation features. Those are implemented via <NavigableToolbar /> within <BlockContextualToolbar />.

What is your proposed solution?

  • Refactor <BlockToolbar /> to include the features of <BlockContextualToolbar />. This would remove <BlockContextualToobar />
  • Remove <BlockContextualToobar /> and its private-api export
  • Replace usage of <BlockContextualToobar /> in edit-site, edit-post, edit-widget, etc headers with `
  • Refactor <SelectedBlockTools /> to use <BlockToolbar /> directly.
  • Rename <SelectedBlockTools /> to something that indicates its true purpose -- making the <BlockToolbar /> into a floating popover. Something like, <FloatingBlockToolbar /> or <BlockToolbarPopover />.
@jeryj jeryj added the [Type] Enhancement A suggestion for improvement. label Nov 10, 2023
@jordesign jordesign added the [Feature] Blocks Overall functionality of blocks label Nov 12, 2023
@jeryj jeryj mentioned this issue Nov 27, 2023
9 tasks
@jeryj
Copy link
Contributor Author

jeryj commented Dec 8, 2023

Closed by #56335

@jeryj jeryj closed this as completed Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants