Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global styles revisions: unsaved revision item is not updated when resetting styles #55866

Closed
ramonjd opened this issue Nov 5, 2023 · 1 comment · Fixed by #55880
Closed

Global styles revisions: unsaved revision item is not updated when resetting styles #55866

ramonjd opened this issue Nov 5, 2023 · 1 comment · Fixed by #55880
Assignees
@ramonjd
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@ramonjd
Copy link
Member

ramonjd commented Nov 5, 2023

Description

Copied over from https://core.trac.wordpress.org/ticket/59533

Props to @sannevndrmeulen for filing it.

Step-by-step reproduction instructions

  1. Navigate to Appearance -> Editor
  2. Select a different style under Styles and Save (this creates a revision)
  3. Open the revisions panel, check that the topmost, saved revision item is selected
  4. Click on the Revisions symbol (a clock) and select Reset to defaults
  5. A new unsaved changes revision item is created however the wrong preview/state is shown

Screenshots, screen recording, code snippet

2023-11-05.18.13.00.mp4

Environment info

  • WordPress 6.4
  • Gutenberg (trunk)

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@ramonjd ramonjd added [Type] Bug An existing feature does not function as intended Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Nov 5, 2023
@ramonjd
Copy link
Member Author

ramonjd commented Nov 6, 2023 •
edited
Loading

Just to note that I think the Reset menu item button will change:

So whatever fix we add here might be temporary.

Fix here:

@ramonjd ramonjd mentioned this issue Nov 6, 2023
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ramonjd ramonjd

Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Global styles revisions: load unsaved revision item into the revisions preview WordPress/gutenberg
1 participant
@ramonjd