Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aside for pullquotes rather than blockquote #5457

Closed
ShinichiNishikawa opened this issue Mar 7, 2018 · 3 comments
Closed

Aside for pullquotes rather than blockquote #5457

ShinichiNishikawa opened this issue Mar 7, 2018 · 3 comments
Labels
[Type] Enhancement A suggestion for improvement.

Comments

@ShinichiNishikawa
Copy link

Issue Overview

Currently, the pull quote block is marked up as <blockquote>. I suggest to change it to <aside>.

HTML 5.2 W3C recommendation 4.3.5. The aside element states as below.

The element can be used for typographical effects like pull quotes ...

Steps to Reproduce (for bugs)

  1. Create a pull quote block in the editor.
  2. See what you get.

Gutenberg Plugin version: 2.3.0

@jeffpaul jeffpaul added the [Type] Enhancement A suggestion for improvement. label Mar 8, 2018
@karmatosed
Copy link
Member

karmatosed commented Apr 27, 2018

Reading this I am not sure totally that this is right to use 'aside'. I am going to ask for a second opinion here just to be sure, @mtias what do you think? Would be good to either close or get a patch in for this if it does make sense to do.

@ZebulanStanphill
Copy link
Member

@karmatosed A pullquote is not part of the main content, so it makes perfect sense to use an <aside>. There is even an example in the spec that shows it being used this way:

<p>He later joined a large company, continuing on the same work.
<q>I love my job. People ask me what I do for fun when I’m not at
work. But I’m paid to do my hobby, so I never know what to
answer. Some people wonder what they would do if they didn’t have to
work... but I know what I would do, because I was unemployed for a
year, and I filled that time doing exactly what I do now.</q></p>

<aside>
  <q> People ask me what I do for fun when I’m not at work. But I’m
  paid to do my hobby, so I never know what to answer. </q>
</aside>

<p>Of course his work — or should that be hobby? —      isn’t his only passion. He also enjoys other pleasures.</p>

Here a <q> tag is nested in the <aside>, but I would suggest using a nested <blockquote> instead, since you can have multiple paragraphs in the Pullquote block.

@mtias
Copy link
Member

mtias commented Oct 12, 2018

We are using figure now for pullquotes.

@mtias mtias closed this as completed Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

5 participants