Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footnotes: footnotes within nested blocks are sometimes counted twice #53009

Closed
andrewserong opened this issue Jul 27, 2023 · 1 comment · Fixed by #53034
Closed

Footnotes: footnotes within nested blocks are sometimes counted twice #53009

andrewserong opened this issue Jul 27, 2023 · 1 comment · Fixed by #53034
Assignees
Labels
[Block] Footnotes Affects the Footnotes Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@andrewserong
Copy link
Contributor

Following on from #52682, it looks like there's still an issue with footnotes sometimes being counted multiple times. It's a bit edge-casey, but I believe a reliable way to reproduce the issue is:

  1. Add a Group block to a post
  2. Add a Quote block within the Group block
  3. Add a footnote to the paragraph within the Quote block as well as to the Citation of the Quote block
  4. Notice that the footnote item is duplicated and synced twice:
2023-07-27.16.39.31.mp4

From looking at #52682, I think this might be a result of iterating over inner blocks as well addValuesForBlocks being called a second time for blocks with InnerBlocks.Content? CC: @ellatrix, @mcsf, @ramonjd, @tellthemachines

@ellatrix
Copy link
Member

It seems to be the citation that is the problem. Adding footnotes to the paragraph seems to work fine

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jul 27, 2023
@ndiego ndiego moved this from 📥 Todo to 🏗️ In Progress in WordPress 6.3.x Editor Tasks Jul 27, 2023
@github-project-automation github-project-automation bot moved this from 🏗️ In Progress to ✅ Done in WordPress 6.3.x Editor Tasks Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Footnotes Affects the Footnotes Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants