Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation block overlay can be not fully visible when it's placed in cover block. #52511

Closed
iamtakashi opened this issue Jul 11, 2023 · 3 comments
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Block] Navigation Affects the Navigation Block [Type] Bug An existing feature does not function as intended

Comments

@iamtakashi
Copy link

Description

The modal has z-index: 100000 and usually appears on top of most things on the screen, for example, the admin bar. However, when it's placed inside a cover block, the z-index isn't 100000 anymore, and the admin bar that has z-index:99999 wins.

Step-by-step reproduction instructions

  1. Open the site editor
  2. Add a cover block
  3. Add a navigation and set overlay menu always
  4. Open the navigation on the front of the site.
  5. Notice you see the admin bar.

Screenshots, screen recording, code snippet

localhost local_ (11)

In this example, it doesn't seem to be a problem, but when we don't have full control for the modal layout, this can be a problem.

Environment info

  • WP 6.2.2
  • Gutenberg Trunk
  • Twenty Twenty-three

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@jordesign jordesign added [Type] Bug An existing feature does not function as intended [Block] Cover Affects the Cover Block - used to display content laid over a background image [Block] Navigation Affects the Navigation Block labels Jul 12, 2023
@jordesign
Copy link
Contributor

I've tested this and confirmed 👍

@getdave getdave changed the title Navigation: Modal can be not fully visible when it's placed in cover block. Navigation block overlay can be not fully visible when it's placed in cover block. Nov 21, 2024
@getdave
Copy link
Contributor

getdave commented Nov 21, 2024

@iamtakashi This looks like a duplicate of #45353. Would you be able to review and close this one out if so?

@getdave
Copy link
Contributor

getdave commented Dec 2, 2024

Closing in favour of #45353

@getdave getdave closed this as completed Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Block] Navigation Affects the Navigation Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants