Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus mode: Lots of unrelated whitespace. #52429

Closed
jameskoster opened this issue Jul 7, 2023 · 4 comments
Closed

Focus mode: Lots of unrelated whitespace. #52429

jameskoster opened this issue Jul 7, 2023 · 4 comments
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

Screenshot 2023-07-07 at 16 01 42

The blue container in the screenshot above encompasses the entirety of the pattern. The whitespace above / below is caused by a couple of things:

  1. Padding on the body applied in global styles
  2. The appended inserter

These combine to somewhat taint the edit experience, as you're never 100% certain whether this whitespace is part of the pattern or not. It makes the overall experience feel a little buggy.

We can probably remove the body padding – it's not really relevant here as a pattern is never going to be viewed in isolation on the frontend.

For the inserter, perhaps we can try hiding it when the pattern is not empty?

@jameskoster jameskoster added [Type] Bug An existing feature does not function as intended [Type] Enhancement A suggestion for improvement. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Jul 7, 2023
@Ren2049
Copy link

Ren2049 commented Jul 7, 2023

If it's the TT3 theme then the padding is part of the global styles layout of the theme. I've started a new site with TT3 from scratch today and had to remove the padding it from the global layout as well, same for the global block spacing which also doesn't belong there.

I guess they did it globally because it worked with their overall design style which is kind of exotic with that high amount of whitespace. For future default themes it might be a good idea to build the default theme with end user modifciation in mind which will be pattern based of course.

There are some good nuggets in this default Webflow design system everybody there is using which could be adapted for WP, basically as a general guideline for how themes should be build: https://finsweet.com/client-first/docs

@jameskoster
Copy link
Contributor Author

The issue here is that it doesn't really make sense for the global padding to be visible when editing a template part in isolation.

@ndiego ndiego moved this to ❓ Triage in WordPress 6.3.x Editor Tasks Jul 10, 2023
@Mamaduka
Copy link
Member

Is this the same issue as #51937?

@jameskoster
Copy link
Contributor Author

Yes it is, thank you.

@github-project-automation github-project-automation bot moved this from ❓ Triage to ✅ Done in WordPress 6.3.x Editor Tasks Jul 11, 2023
@annezazu annezazu moved this to Done in Polish Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended [Type] Enhancement A suggestion for improvement.
Projects
Status: Done
Development

No branches or pull requests

3 participants