Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Theme Previews: add option to switch between different themes to preview #50918

Open
annezazu opened this issue May 24, 2023 · 6 comments
Labels
[Feature] Themes Questions or issues with incorporating or styling blocks in a theme. Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

This was raised by @carolinan as part of the FSE Outreach Program's Rapid Revamp call for testing:

Once I clicked on the Live Preview link and entered the Site Editor with the Navigation Sidebar (the dark grey menu area) on the left, I was expecting to be able to navigate between all the installed block themes and WordPress.org block themes, similar to how the preview of classic themes work.

Here's the experience with classic themes to imagine for block themes in the Site Editor previewing mechanism:

classic.theme.preview.mov

I remember seeing some designs floating around that considered this. cc @WordPress/gutenberg-design just in case!

@annezazu annezazu added [Type] Enhancement A suggestion for improvement. [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. labels May 24, 2023
@annezazu
Copy link
Contributor Author

Huzzah, found the design showing access to block themes from the Design section.

237068191-90aff2c6-ad59-4359-83c6-7a8f22f6c72d

Worth reusing here :)

@jasmussen
Copy link
Contributor

I think @jameskoster has a separate issue for the "meta links" in the save hub, and has a newer design for themes access.

@jameskoster
Copy link
Contributor

and has a newer design for themes access

This one:

Screenshot 2023-05-25 at 14 25 01

Perhaps there's a way for that element to accommodate inline theme switching, rather than sending folks off to the legacy themes grid in wp-admin?

Theme

The theme switch can be expressed in the save modal:

Screenshot 2023-05-25 at 14 49 03

The trade-off with this approach is that it would only be able to handle block themes.

@richtabor
Copy link
Member

Perhaps there's a way for that element to accommodate inline theme switching, rather than sending folks off to the legacy themes grid in wp-admin?

I don't think it's particularly useful without visuals representing the themes (like classic has). Seems a bit too forward-facing too to have theme switching accessible from the main SE navigation. I think a "Browse themes" link would work fine until a future where there is theme switching (including partial theme switching) in the SE.

@scruffian
Copy link
Contributor

It's technically very easy to do: #50388

@jameskoster
Copy link
Contributor

I think a "Browse themes" link would work fine until a future where there is theme switching (including partial theme switching) in the SE.

I agree this would be a satisfactory bare minimum.

But it would be nice to have quick switching while previewing a theme. It's currently a very tedious process (see the video in Ben's PR).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Themes Questions or issues with incorporating or styling blocks in a theme. Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

5 participants