Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert renderAdditionalBlockUI to Component and accept props #50827

Closed
getdave opened this issue May 22, 2023 · 1 comment · Fixed by #51163
Closed

Convert renderAdditionalBlockUI to Component and accept props #50827

getdave opened this issue May 22, 2023 · 1 comment · Fixed by #51163
Assignees
Labels
[Feature] List View Menu item in the top toolbar to select blocks from a list of links.

Comments

@getdave
Copy link
Contributor

getdave commented May 22, 2023

In #50774 we augmented the renderAdditionalBlockUI render callback. Before this becomes public we should make it accept a Component rather than a function.

This will also solve the issue of a potentially ever expanding list of positional arguments as mentioned in the discussion referenced below.

.......

This now forms part of the API of renderAdditionalBlockUI as positional params. If and when renderAdditionalBlockUI becomes part of the stable API, insertedBlock and setInsertedBlock might not be applicable for some use cases, but we also might want to add additional params at some stage. Would it be worth switching renderAdditionalBlockUI to use an object as its param?

Originally posted by @andrewserong in #50774 (comment)

@Mamaduka
Copy link
Member

Mamaduka commented Jun 1, 2023

I started working on this in #51163. I need to do a bit more testing, but PR is ready for early feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] List View Menu item in the top toolbar to select blocks from a list of links.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants