Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern & Media List Items: Use consistent admin focus style #50757

Closed
richtabor opened this issue May 18, 2023 · 5 comments
Closed

Pattern & Media List Items: Use consistent admin focus style #50757

richtabor opened this issue May 18, 2023 · 5 comments
Assignees
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Type] Bug An existing feature does not function as intended

Comments

@richtabor
Copy link
Member

richtabor commented May 18, 2023

Let's update the focus state style applied to Inserter list items, so that it is in line with what we employ throughout the experience.

Current

current

Expected

expected
@richtabor richtabor added [Type] Bug An existing feature does not function as intended [Feature] Inserter The main way to insert blocks using the + button in the editing interface labels May 18, 2023
@richtabor
Copy link
Member Author

Could very well be related:

CleanShot 2023-05-18 at 14 58 41

@richtabor richtabor changed the title Pattern & Media Inserter: Use consistent admin focus style Pattern & Media List Item: Use consistent admin focus style May 18, 2023
@richtabor richtabor changed the title Pattern & Media List Item: Use consistent admin focus style Pattern & Media List Items: Use consistent admin focus style May 18, 2023
@mikachan
Copy link
Member

mikachan commented Jun 9, 2023

I believe this should be fixed with #50819. Please re-open if not!

@mikachan mikachan closed this as completed Jun 9, 2023
@juanfra
Copy link
Member

juanfra commented Jun 13, 2023

From what I see in #50819 we're adding changes to the hover state of the icon. I believe those changes are not fixing what was initially reported in this issue, which concerns the focus style.

By inspecting the elements, I see that the styles for the image under "current" is using the border property for the focus style whereas we use an inset box-shadow in other places. It'll likely be fixed by adjusting the focus style for the "item group" component.

@mikachan
Copy link
Member

Good spot, @juanfra. I've opened another PR to address this: #51576

@juanfra
Copy link
Member

juanfra commented Jun 16, 2023

Thanks for working on this, Sarah 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Type] Bug An existing feature does not function as intended
Projects
Status: Done
Development

No branches or pull requests

3 participants