Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSE: when editing a navigation menu item's label, focus is lost each time you type a character #50255

Closed
nekohayo opened this issue May 2, 2023 · 1 comment · Fixed by #52428
Assignees
Labels
[Block] Navigation Affects the Navigation Block [Block] Page List Affects the Page List Block Browser Issues Issues or PRs that are related to browser specific problems [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended

Comments

@nekohayo
Copy link

nekohayo commented May 2, 2023

Description

Everytime I type a character in the editing field for menu labels, it defocuses the field, so I have to click to refocus it after every typed character.

Furthermore, this makes it impossible to type accented characters using dead keys (ex: typing ^ then e to create ê).

Step-by-step reproduction instructions

  1. Insert a menu in the header template of your website and edit its contents using the sidebar on the right
  2. Try to modify the label of an item in a submenu

See video below.

Screenshots, screen recording, code snippet

wordpress-6.2-gutenberg-menu-label-editing-focus-issue.webm

Environment info

  • Fully updated WordPress 6.2, with the stock Gutenberg version that comes with it
  • Tested on Firefox 112.0.1 on Fedora Linux 38, in the GNOME Wayland session.

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@carolinan carolinan added [Block] Navigation Affects the Navigation Block [Block] Page List Affects the Page List Block labels May 3, 2023
@carolinan
Copy link
Contributor

carolinan commented May 3, 2023

I am able to reproduce this using:
WordPress 6.2, no plugins, Twenty Twenty-Three
Mac OS
Firefox version 112.0.2

Tested the regular navigation block link, submenu, page list.

But I can not reproduce it using Chrome version 112.0.5615.137

@carolinan carolinan added [Type] Bug An existing feature does not function as intended Browser Issues Issues or PRs that are related to browser specific problems [a11y] Keyboard & Focus labels May 3, 2023
@annezazu annezazu added this to Polish May 10, 2023
@annezazu annezazu moved this to Needs development in Polish May 10, 2023
@jorgefilipecosta jorgefilipecosta self-assigned this Jul 7, 2023
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jul 7, 2023
@jorgefilipecosta jorgefilipecosta moved this from Needs development to Needs review in Polish Jul 7, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Jul 10, 2023
@priethor priethor moved this from Needs review to Done in Polish Jul 10, 2023
@priethor priethor added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). and removed [a11y] Keyboard & Focus labels Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Block] Page List Affects the Page List Block Browser Issues Issues or PRs that are related to browser specific problems [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants