Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear how to enable controls after typing #498

Closed
ellatrix opened this issue Apr 24, 2017 · 14 comments · Fixed by #556
Closed

Unclear how to enable controls after typing #498

ellatrix opened this issue Apr 24, 2017 · 14 comments · Fixed by #556
Assignees
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript [Priority] High Used to indicate top priority items that need quick attention [Type] Question Questions about the design or development of the editor.
Milestone

Comments

@ellatrix
Copy link
Member

Once you type in an editable field, the controls disappear, and it is unclear how to make them show again. The only way seems to be to select another block, and then select then old one again.

Maybe we should always show controls on mousedown touchstart?

@ellatrix ellatrix added Framework Issues related to broader framework topics, especially as it relates to javascript [Type] Question Questions about the design or development of the editor. labels Apr 24, 2017
@youknowriad
Copy link
Contributor

Yep I think this is a bug and they should reappear when clicking. Like the prototypes.

@ellatrix
Copy link
Member Author

Cool, I'll have a look then.

@ellatrix ellatrix self-assigned this Apr 24, 2017
@ellatrix ellatrix added this to the Prototype Parity milestone Apr 26, 2017
@mtias mtias added the [Priority] High Used to indicate top priority items that need quick attention label Apr 27, 2017
@ellatrix
Copy link
Member Author

Unassigning for now because I already have some high priority ones.

@ellatrix ellatrix removed their assignment Apr 27, 2017
@mtias
Copy link
Member

mtias commented Apr 28, 2017

The original intention was that controls would appear on mouse move after typing on the selected block.

@ellatrix
Copy link
Member Author

It seems like mousedown/touchstart and some keys might be enough. Mousemove seems like something that is hard to do across different devices, and might also be a bit distracting.

@mtias
Copy link
Member

mtias commented Apr 28, 2017

If I'm typing and I want to switch to bold, I don't want to click on anything because the block is already focused. The hiding of the formatting while typing is mainly to avoid distraction, but as soon as I switch from typing to moving the cursor (one example) the controls should become visible.

@ellatrix
Copy link
Member Author

Wouldn't you have to select the text first, or put the caret on the word?

@mtias
Copy link
Member

mtias commented Apr 28, 2017

I mean in the case where I want to switch to italics before writing what I want to be in italics.

@ellatrix
Copy link
Member Author

Yeah, I guess I thought in that case people would more often use keyboard/text shortcuts for continuous typing, whereas the UI would be used more to format afterwards.

@mtias
Copy link
Member

mtias commented Apr 28, 2017

Yes, probably. Let's see how #556 feels.

@mtias
Copy link
Member

mtias commented Apr 28, 2017

There's also the case of having to reselect the block to access the other controls, like alignment.

@ellatrix
Copy link
Member Author

Fair enough. Let's try adding to it gradually and see how it feels. :)

@jasmussen
Copy link
Contributor

Good thoughts here already. Here's how I've been thinking of it.

Everything is a block. Hovering over it indicates the extent of the block. But when you click a block, or arrow-key into it, that block now is now selected, and it is selected until you select another block. Even if you start typing, the block is still technically selected.

All block boundaries & controls fade out as soon as you start typing, so you can focus on the content. But as soon as you move the mouse, the boundaries & controls fade in again, as this indicates you might want to manipulate the blocks. Keep in mind mobile is slightly different in that the formatting is docked at the top of the screen always.

☝️ this is how I've been picturing it. It's okay to revisit or think of other approaches, but it's a key value that blocks feel "blocky and manipulable".

@mtias
Copy link
Member

mtias commented May 4, 2017

Let's close this as it's working better now, and open a task to explore mousemove.

@mtias mtias closed this as completed May 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript [Priority] High Used to indicate top priority items that need quick attention [Type] Question Questions about the design or development of the editor.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants