Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PaletteEdit: ColorPicker popover position can't be changed #49040

Closed
mirka opened this issue Mar 13, 2023 · 1 comment · Fixed by #49975
Closed

PaletteEdit: ColorPicker popover position can't be changed #49040

mirka opened this issue Mar 13, 2023 · 1 comment · Fixed by #49975
Labels
[Package] Components /packages/components [Type] Enhancement A suggestion for improvement.

Comments

@mirka
Copy link
Member

mirka commented Mar 13, 2023

What problem does this address?

When clicking on a color swatch, the ColorPicker popover opens to the left side of the component with a 20px offset. This positioning is coupled to the block editor sidebar and cannot be changed.

CleanShot.2023-03-14.at.01.16.37.mp4

<Popover
placement="left-start"
offset={ 20 }

In Storybook, the result looks glitchy:

CleanShot.2023-03-14.at.01.17.15.mp4

What is your proposed solution?

The popover positioning should not be coupled to the block editor.

Related: All the components with the __experimentalIsRenderedInSidebar prop.

@mirka mirka added the [Package] Components /packages/components label Mar 13, 2023
@kathrynwp kathrynwp added the [Type] Enhancement A suggestion for improvement. label Mar 13, 2023
@ciampo
Copy link
Contributor

ciampo commented Mar 14, 2023

cc @jorgefilipecosta — it would be great if we could work towards removing the __experimentalIsRenderedInSidebar from the @wordpress/components package, since it introduces tight coupling with the block editor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants