Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add descriptions to all panels in the Site Editor's dark sidebar #48718

Closed
6 of 7 tasks
jameskoster opened this issue Mar 3, 2023 · 5 comments · Fixed by #48739
Closed
6 of 7 tasks

Add descriptions to all panels in the Site Editor's dark sidebar #48718

jameskoster opened this issue Mar 3, 2023 · 5 comments · Fixed by #48739
Assignees
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Feedback Needs general design feedback. Needs Design Needs design efforts. [Priority] High Used to indicate top priority items that need quick attention [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.

Comments

@jameskoster
Copy link
Contributor

jameskoster commented Mar 3, 2023

The description affordance in the design provides space for us to explain complex concepts like templates and template parts, and generally make the site editing experience feel more friendly / approachable. We should make use of this affordance and to empty panels like this one:

Screenshot 2023-03-03 at 10 16 45

@jameskoster jameskoster added Needs Design Needs design efforts. [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Mar 3, 2023
@jameskoster
Copy link
Contributor Author

jameskoster commented Mar 3, 2023

A first pass at those panels that do not already have a dedicated issue:

Templates

Express the layout of your site with templates.

Manage templates

Create new templates, or reset any customisations made to the templates supplied by your theme.

Template Parts

Template Parts are small pieces of a layout that can be reused across multiple templates and always appear the same way. Common template parts include the site header, footer, or sidebar.

Manage template parts

Create new template parts, or reset any customisations made to the template parts supplied by your theme.

@jameskoster jameskoster added the Needs Design Feedback Needs general design feedback. label Mar 3, 2023
@jasmussen jasmussen added the [Priority] High Used to indicate top priority items that need quick attention label Mar 3, 2023
@jasmussen
Copy link
Contributor

Good one. This issue is one of the most important ones we need to still land for 6.2. Just going through these and adding my own:

  • Design
    "Customise your Navigation menus, Templates, and more."
    • Design → Navigation (:white_check_mark:)
      • Design → Navigation → Page
        "This is a static page.", at minimum
      • Design → Navigation → Posts page
        Ideally "This is your posts page." but "This is a static page." at minimum.
    • Design → Templates
      "Express the layout of your site with templates." seems fine.
      • Design → Templates → Manage all templates
        "Create new templates, or reset any customisations made to the templates supplied by your theme." seems good.
    • Design → Template Parts
      "Template Parts are small pieces of a layout that can be reused across multiple templates and always appear the same way. Common template parts include the site header, footer, or sidebar." seems good.
      • Design → Template Parts → Manage all template parts
        "Create new template parts, or reset any customisations made to the template parts supplied by your theme." seems good.
      • Design → Template Parts → [any random template part]
        At minimum: "This is your [any random template part] part."
      • Design → Template Parts → [any random custom template part]
        At minimum: "This is your [any custom template part] part."

@jasmussen
Copy link
Contributor

Essentially, no drilldown detail page should ever be empty. There should always be, at minimum, a description.

footer template part with missing description

It might be useful (not urgent) to refactor the component so a description becomes required, i.e. it outputs something like "This detail page is missing a description".

@jameskoster
Copy link
Contributor Author

"This is your posts page."

That's a great point. It would be nice if we can mark all those key pages, like in the wp-admin list view:

Screenshot 2023-03-03 at 14 26 52

@jasmussen
Copy link
Contributor

Yep. But if it becomes a challenge to snatch those special descriptions, we can do that in a V2, a V1 should at least have a "page" description. 👍 👍

@jorgefilipecosta jorgefilipecosta self-assigned this Mar 3, 2023
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Mar 3, 2023
@ndiego ndiego moved this to ❓ Triage in WordPress 6.2 Editor Tasks Mar 5, 2023
@github-project-automation github-project-automation bot moved this from ❓ Triage to ✅ Done in WordPress 6.2 Editor Tasks Mar 6, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Feedback Needs general design feedback. Needs Design Needs design efforts. [Priority] High Used to indicate top priority items that need quick attention [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants