Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Areas" from template details dropdown #48487

Closed
richtabor opened this issue Feb 27, 2023 · 2 comments · Fixed by #48490
Closed

Remove "Areas" from template details dropdown #48487

richtabor opened this issue Feb 27, 2023 · 2 comments · Fixed by #48490
Assignees
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Enhancement A suggestion for improvement.

Comments

@richtabor
Copy link
Member

Now that we have List view and improved focus states for the template parts, it's a bit redundant having areas listed here as well. Let's remove these.

CleanShot 2023-02-24 at 17 59 32

@richtabor richtabor added [Type] Enhancement A suggestion for improvement. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Feb 27, 2023
@richtabor richtabor moved this to 🏗️ In Progress in WordPress 6.2 Editor Tasks Feb 27, 2023
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Feb 27, 2023
@hanneslsm
Copy link

hanneslsm commented Feb 27, 2023

I like this, but since this makes the "clear customizations" even more prominent (it's now basically the only thing you can do in the dropdown), I'd like to point to one issue, that would add a confirmation modal before clearing the customizations. #39124

@mtias
Copy link
Member

mtias commented Feb 27, 2023

Indeed — the collapsed list view now does a better job of presenting the main sections of a template, whether template part based or not. This menu is now rather confusing, particularly given it focuses on the first area it finds by default, so it adds an outline on the canvas.

@hannesdev with revisions for templates exposed, a confirmation seems less necessary (you can restore your changes), but it might still be nice to show and can be a way to tell people that they have revisions (if enabled).

@github-project-automation github-project-automation bot moved this from 🏗️ In Progress to ✅ Done in WordPress 6.2 Editor Tasks Feb 27, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Enhancement A suggestion for improvement.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants