Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadow panel not showing for Group block #48038

Closed
bradhogan opened this issue Feb 13, 2023 · 4 comments · Fixed by #48043
Closed

Shadow panel not showing for Group block #48038

bradhogan opened this issue Feb 13, 2023 · 4 comments · Fixed by #48043
Assignees

Comments

@bradhogan
Copy link

Description

Looks like Shadow has been added to the Group options (at least in the global styles) but there's not an option to choose a shadow option(s) once inside the panel. Here's a video better showing the issue.

Love that this is finally coming into the editor. It's great to see it working with the global buttons block (would love to see it in the individual button block panel as well - same with above Group block).

#46502

Step-by-step reproduction instructions

See video

Screenshots, screen recording, code snippet

No response

Environment info

  • wp 6.1.1
  • gutenberg 15.1.0
  • chrome
  • macos

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@richtabor
Copy link
Member

Hey @bradley2083 — it looks like that's a remnant of an earlier concept of placing borders and shadows together. The singular "Button" block is the only block to support the new shadow control (for now) — as it's still very new.

@richtabor
Copy link
Member

We do need to fix some of those headers though; "Border & Shadow" — but should just say "Border".

Here's what I'm seeing for the Group block (trunk) in the Global Styles sidebar.

CleanShot.2023-02-13.at.14.41.20.mp4

And for comparison, here's what I'm seeing for the Button block:

CleanShot.2023-02-13.at.14.43.07.mp4

@bradhogan
Copy link
Author

Thanks @richtabor

@skorasaurus
Copy link
Member

#48043 closes this PR

@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants