Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hitting ESC within the Link Control in the list view seems to completely loose focus. #48015

Closed
getdave opened this issue Feb 13, 2023 · 2 comments
Closed

Hitting ESC within the Link Control in the list view seems to completely loose focus. #48015

getdave opened this issue Feb 13, 2023 · 2 comments
Assignees
@scruffian
Labels
[Block] Navigation Affects the Navigation Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended

Comments

@getdave
Copy link
Contributor

getdave commented Feb 13, 2023

Add Custom Link then once Link UI shows up hit ESC. Notice focus is now on the body or iframe. Should be back where it came from.
@getdave getdave added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Block] Navigation Affects the Navigation Block labels Feb 13, 2023
@getdave getdave mentioned this issue Feb 13, 2023
Closed
15 tasks
@scruffian
Copy link
Contributor

I think this is also fixed by #48029.

@scruffian scruffian self-assigned this Feb 14, 2023
@ndiego ndiego moved this to ❓ Triage in WordPress 6.2 Editor Tasks Feb 14, 2023
@draganescu
Copy link
Contributor

I have tested this and when closing the popover from the linkUI document.activeElement is set to <button class="components-button block-inserter... which is the element of the square inserter at the bottom.

@github-project-automation github-project-automation bot moved this from ❓ Triage to ✅ Done in WordPress 6.2 Editor Tasks Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scruffian scruffian

Labels
[Block] Navigation Affects the Navigation Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended
Projects
No open projects
WordPress 6.2 Editor Tasks
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@draganescu @scruffian @getdave