Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Control select and edit link suggestion without auto-apply #47543

Open
getdave opened this issue Jan 30, 2023 · 5 comments
Open

Link Control select and edit link suggestion without auto-apply #47543

getdave opened this issue Jan 30, 2023 · 5 comments
Assignees
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback.

Comments

@getdave
Copy link
Contributor

getdave commented Jan 30, 2023

Currently selecting a search suggestion within the Link Control component will automatically apply that link and close the UI.

@joedolson is suggesting that instead the suggestion should be selected but the link not applied until you have "committed" your changes. Presumanly by hitting "Apply".

I'm going to ask for input from @WordPress/gutenberg-design as this will be a significant change to the UX which may require additional input.


At the moment, there's no way to select a link from a search & adjust its settings in a single step. Since selecting the link creates the link and closes the panel, you have to re-select the link and edit to change its settings. This is a minor annoyance for mouse users, but fairly significant if you're navigating by keyboard.

Originally posted by @joedolson in #47310 (comment)

@getdave getdave added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) labels Jan 30, 2023
@getdave getdave self-assigned this Jan 30, 2023
@getdave getdave added the Needs Design Feedback Needs general design feedback. label Jan 30, 2023
@jameskoster
Copy link
Contributor

Since selecting the link creates the link and closes the panel, you have to re-select the link and edit to change its settings.

I do see how this would be frustrating, but it's only applicable to internal links, for which it seems less likely you'd need to adjust any of the settings?

It seems a bit of a shame to introduce the extra click. But in practice perhaps it's not so bad? I don't have a strong feeling and wouldn't object to trying this. Keen to hear thoughts from others.

@getdave
Copy link
Contributor Author

getdave commented Jan 30, 2023

I think maybe we could make a small change here as a middle ground to help. When a user selects a suggestion we allow it to auto-apply but we wouldn't close the Link UI. That means if a user has additional edits they can tab 1 stop to "edit" and then make the changes.

Currently we close the Link UI entirely.

@jameskoster
Copy link
Contributor

Hmm I think that might undermine the apply button a bit. Closing the panel works because it's more obvious. Imo it wouldn't hurt to try the original suggestion (requiring a click of the Apply button) to see how it feels, then gather more feedback.

@github-actions
Copy link

Hi,
This issue has gone 180 days without any activity. This means it is time for a check-in to make sure it is still relevant. If you are still experiencing this issue with the latest versions, you can help the project by responding to confirm the problem and by providing any updated reproduction steps.
Thanks for helping out.

@getdave
Copy link
Contributor Author

getdave commented Dec 14, 2023

I'm hopeful that #50891 will address this in time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback.
Projects
None yet
Development

No branches or pull requests

3 participants