Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gallery Block: Focus is lost after inserting images #47326

Closed
t-hamano opened this issue Jan 21, 2023 · 2 comments
Closed

Gallery Block: Focus is lost after inserting images #47326

t-hamano opened this issue Jan 21, 2023 · 2 comments
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended

Comments

@t-hamano
Copy link
Contributor

t-hamano commented Jan 21, 2023 •
edited
Loading

Description

In the gallery block, after inserting an image, the gallery block itself should be expected to receive focus, just like any other block. However, the loss of focus makes it difficult to seamlessly manipulate the block.

This problem occurs at least both when selecting images from the media library and when uploading media.

Screenshots, screen recording, code snippet

82f6633e880f432e0eeaddfb2cfa6afb.mp4
@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Block] Gallery Affects the Gallery Block - used to display groups of images [a11y] Keyboard & Focus labels Jan 21, 2023
@t-hamano t-hamano mentioned this issue Jan 21, 2023
Merged
@tomdevisser
Copy link
Member

Is this a duplicate of #27521? Cause in that case this one can be closed.

@t-hamano
Copy link
Contributor Author

@tomdevisser
Thanks for pointing that out! I think this issue is exactly the same problem as #27521, so let's close it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@priethor @t-hamano @tomdevisser