Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dead (or bad) code in gutenberg_meta_box_post_form_hidden_fields() #4714

Closed
tfrommen opened this issue Jan 28, 2018 · 1 comment · Fixed by #4757
Closed

Dead (or bad) code in gutenberg_meta_box_post_form_hidden_fields() #4714

tfrommen opened this issue Jan 28, 2018 · 1 comment · Fixed by #4757
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time

Comments

@tfrommen
Copy link
Member

Issue Overview

Maybe I'm missing something, but as far as I can see, there is either dead or at least bad (as in faulty) code in the gutenberg_meta_box_post_form_hidden_fields function to be found.

The active_post_lock variable is undefined, because it is neither actively defined, nor imported from the global scope, nor do I see some other source of definition (e.g., the not-to-be-used extract function).
@youknowriad
Copy link
Contributor

Good catch, should probably be deleted

@youknowriad youknowriad added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Jan 29, 2018
@Rahmon Rahmon mentioned this issue Jan 30, 2018
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix unset variable Rahmon/gutenberg
2 participants
@youknowriad @tfrommen