Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: WCAG violation by different order of Blocks & Patterns in block inserter in Post- and Site-Editor #47113

Closed
burnuser opened this issue Jan 12, 2023 · 12 comments · Fixed by #55688
Assignees
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@burnuser
Copy link

Description

As reported in core https://core.trac.wordpress.org/ticket/57431 and advised to report it here.
(And please don't play "not right located here" tennis!)

Step-by-step reproduction instructions

In the block inserter of the post-editor are tabs ordered: Blocks - Patterns
In the block inserter of the site-editor are tabs ordered: Patterns - Blocks

It is confusing (and very bad UI design) for ALL users, when parts in the - expectable - same user interface change places.

And it is a direct violation of the "Web Content Accessibility Guidelines"
=> "Make Web pages appear and operate in predictable ways"
https://www.w3.org/TR/WCAG21/#consistent-navigation

Screenshots, screen recording, code snippet

No response

Environment info

WP 6.1.1
with and without Gutenberg

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@kathrynwp kathrynwp added [Feature] Inserter The main way to insert blocks using the + button in the editing interface [Type] Enhancement A suggestion for improvement. [a11y] Labelling labels Jan 12, 2023
@carolinan
Copy link
Contributor

carolinan commented Jan 13, 2023

I don't think it is that simple. Patterns are highlighted in the site editor because there you are working mostly on design, as opposed to adding many single blocks. It might still very well be the case that consistency is more important.

@joedolson
Copy link
Contributor

Regarding the WCAG violation question, I'm not sure this actually is a violation; it's debatable whether the site editor and the post editor should really be considered as the same interface. The two interfaces perform different functions, edit different fields, and have a lot of very different features, though the interfaces are similar.

However, I do think that consistency and muscle memory play a significant role in making the interface easier to use, and having these tools in a different order in the two editors does not seem beneficial to me. I'm not convinced that the argument "you are working mostly on design in the block editor" is sufficient to merit an otherwise arbitrary change in feature order.

@burnuser
Copy link
Author

About same or not the same editor: at least the WordPress promotion advertises it as "same editor for posts and templates"

But of course more important is usability. And in my experience I work regularly with the post editor and have automated the tasks using block-inserter with Blocks at first and Patterns in the second tab.
And when I - sometimes - have something to do in the site-editor, the different order of blocks and patterns breaks every time my workflow!
My focus is on the content and should not be requested by changes in the common user interface!

And about priority of patterns or blocks:
1.) Maybe someone starts with a pattern (1 time), but all following steps of adaptation requires blocks (many times)!
2.) I think most people starts not with a fresh template, but want to change an existing one. And need blocks for this task!
3.) Nobody knows really, how the site-editor is used by other people. So, the need of consistency in the user interface for usability and accessibility is the only certainty.

@carolinan
Copy link
Contributor

@WordPress/gutenberg-design I wanted to highlight this feedback for your consideration, not only for the positioning of the blocks and patterns tab panels, but also for 45722.

@priethor priethor added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). and removed [a11y] Labelling labels Jul 24, 2023
@joedolson
Copy link
Contributor

I think that changing the order because we're making assumptions about what users are doing or prioritizing is overstepping; we should offer an interface that is predictable, and that means keeping common items in the same order and location as much as we can.

In my opinion, the consistent order should be Blocks > Patterns > Media in both environments.

@richtabor
Copy link
Member

In my opinion, the consistent order should be Blocks > Patterns > Media in both environments.

I agree. Consistency is key.

@joedolson joedolson removed the Needs Accessibility Feedback Need input from accessibility label Aug 11, 2023
@carolinan carolinan self-assigned this Aug 21, 2023
@carolinan carolinan assigned carolinan and unassigned carolinan Oct 26, 2023
@carolinan
Copy link
Contributor

I was going to start on this but found that it has already been solved. The order is the same in both editors.
I tested on 6.4 RC 2.

@carolinan carolinan removed their assignment Oct 27, 2023
@burnuser
Copy link
Author

NO, it is NOT resolved!

When you start with website editor, you are in the regular page editing mode, where the order is Blocks > Patterns

But when you change to template editing mode, the order is CHANGED to Patterns > Blocks (even in 6.4 RC 2)

@burnuser
Copy link
Author

And that the order changes in the same editor, dependent on the edited content, makes the confusion - obviously - even worse!

@joedolson
Copy link
Contributor

Confirming. If you go to Editor > Pages and select a page, then open the canvas to edit, the order is Blocks / Patterns / Media.

If you go to Editor > Templates and select a template, then open the canvas to edit, the order is Patterns / Blocks / Media.

Reopening.

@joedolson joedolson reopened this Oct 27, 2023
@joedolson
Copy link
Contributor

@burnuser Please, do remember to try and be polite when communicating with other contributors here. We're all trying, and being shouted at is not constructive or helpful.

@alexstine
Copy link
Contributor

Just going to add a quick 👍 here. UX should be simplified. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants