Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflows: Run PHP unit tests against previous WP version #46979

Closed
ockham opened this issue Jan 9, 2023 · 0 comments · Fixed by #46983
Closed

Workflows: Run PHP unit tests against previous WP version #46979

ockham opened this issue Jan 9, 2023 · 0 comments · Fixed by #46983
Assignees
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.

Comments

@ockham
Copy link
Contributor

ockham commented Jan 9, 2023

What problem does this address?

Gutenberg is supposed to work on the current WordPress version, and on the previous one.

While we have solid test coverage for the current WP version, we don't currently have any coverage for the previous one. This sometimes results in failures when people attempt to run GB on the previous version, as seen e.g. #46811.

What is your proposed solution?

Per this discussion, PHP unit tests should catch the bulk of issues like that (while not adding as much overhead as JS unit tests, or e2e tests).

Since #46510 moves PHP unit tests from unit-tests.yml (which they share with JS unit tests) into their own workflow file, let's wait for it to land so that we can then consider adding currentWordPress - 1 to the PHP unit test matrix.

cc/ @noahtallen @anton-vlasenko

@ockham ockham added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Jan 9, 2023
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jan 9, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants