Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List: allow indenting with Tab #45404

Closed
Marc-pi opened this issue Oct 30, 2022 · 12 comments
Closed

List: allow indenting with Tab #45404

Marc-pi opened this issue Oct 30, 2022 · 12 comments
Labels
[Block] List Affects the List Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Dev Ready for, and needs developer efforts [Status] Blocked Used to indicate that a current effort isn't able to move forward [Type] Enhancement A suggestion for improvement.

Comments

@Marc-pi
Copy link

Marc-pi commented Oct 30, 2022

What problem does this address?

It is not possible to ident Lists quickly with tabs keyboard button.
The only way actually is to use the toolbar button.
It is a major need for all of us that are daily building contents with WP FSE.

  • I've checked within the issue tracker in Gutenberg Plugin backlog,
  • I've checked also in Gutenberg 14.4/14.5
  • I did not find quickly the List v2 Roadmap, maybe it is in it already ?

Let's poke @ellatrix who seems to manage the block improvements with dexterity ;-)

image

What is your proposed solution?

Just like in Google Docs or MS Word, since users took (for ages) the habit to use the tabs to indent lists.

@ellatrix
Copy link
Member

We will add Tab. Requires better methods to navigate in the editor though. See #45157 (comment).

@Marc-pi
Copy link
Author

Marc-pi commented Oct 31, 2022

ok, thanks
Needed, just for memo :

  • Tab (indent)
  • Shift + Tab (un-indent)

@kathrynwp kathrynwp added [a11y] Keyboard & Focus [Block] List Affects the List Block [Type] Enhancement A suggestion for improvement. labels Oct 31, 2022
@danielbachhuber
Copy link
Member

Needed, just for memo :

* Tab (indent)

* Shift + Tab (un-indent)

This works great in the Classic Block 😊

Previously #4181 and #9611

@priethor priethor added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). and removed [a11y] Keyboard & Focus labels Jul 24, 2023
@annezazu annezazu changed the title List v2 > Writing XP > Indent with Tab List v2: allow indenting with Tab Aug 3, 2023
@annezazu annezazu added the Needs Dev Ready for, and needs developer efforts label Aug 3, 2023
@mtias
Copy link
Member

mtias commented Aug 4, 2023

The only way actually is to use the toolbar button.

You can actually use space and backspace to indent and unindent with the caret on the first position of a list. The only reason tab doesn't work is because there's an accessibility conflict with regards to navigation expectations. The solution to which has been elusive. The most promising path is to couple the behaviors with the "constrain focus" setting.

@mtias mtias changed the title List v2: allow indenting with Tab List: allow indenting with Tab Aug 4, 2023
@alexstine
Copy link
Contributor

Yes, this will be possible when Tab/Shift+Tab are no longer reserved navigation keys and they can be block-based actions. Until then, this is blocked.

@alexstine alexstine added the [Status] Blocked Used to indicate that a current effort isn't able to move forward label Aug 4, 2023
@simison
Copy link
Member

simison commented Aug 7, 2023

Would highlight a list item, and then pressing tab while list item is highlighted work for accessibility in Gutenberg? Similar works in browsers natively.

Screen recording below:

Screen.Recording.2023-08-07.at.22.31.17.mov

@alexstine
Copy link
Contributor

That is probably fine for A11Y but not very discoverable. Needs docs at the very least.

@ellatrix
Copy link
Member

ellatrix commented Aug 8, 2023

@simison I don't think that's native behaviour. Looks like that's added to the textarea by Github. Natively tab goes from textarea to the next element even if there's an uncollapsed selection.

@ellatrix
Copy link
Member

Related: #37336

@afercia
Copy link
Contributor

afercia commented Nov 28, 2023

You can actually use space and backspace to indent and unindent with the caret on the first position of a list.

Yes and I'd like to note that also on Google Docs Tab / Shift+Tab indent and unindent only when:

  • caret is at first position of a list item
  • a list item 'row' is selected

When the caret is in the middle or at the end, Tab / Shift+Tab don't do anything, and for good reasons.

Additionally, in the WordPress Editor, Shift+Tab was established long time ago to be the main affordance to navigate with the keyboard from the selected block to the block toolbar. This must always work under all circumstances and never break.

@annezazu
Copy link
Contributor

annezazu commented Feb 8, 2024

After a review by core editor triage and core editor tech leads on the WordPress 6.5 release team, this issue is being removed from the release.

@Marc-pi
Copy link
Author

Marc-pi commented Mar 13, 2024

@ellatrix ok, done through #59199
thanks ! close

@Marc-pi Marc-pi closed this as completed Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] List Affects the List Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Dev Ready for, and needs developer efforts [Status] Blocked Used to indicate that a current effort isn't able to move forward [Type] Enhancement A suggestion for improvement.
Projects
No open projects
Status: Done
Development

No branches or pull requests

10 participants