Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slash command, to add an inner block, in "Add Citation" section of Quote Block is still allowed #44617

Closed
jpollock opened this issue Sep 30, 2022 · 2 comments · Fixed by #44634
Assignees
Labels
[Block] Quote Affects the Quote Block [Type] Bug An existing feature does not function as intended

Comments

@jpollock
Copy link

Description

In the Quote Block, in Add Citation field, the slash command is showing up when it should not.

Step-by-step reproduction instructions

  1. Create a new post
  2. Add a Quote block.
  3. Place cursor in the "Add citation" section of the Quote block.
  4. Type "/".
  5. Select one of the available blocks.

Screenshots, screen recording, code snippet

issue_with_quote_add_inner_block

Environment info

WordPress version: WordPress 6.1-beta2 (running in Local)
Gutenberg version: N/A
Are all plugins except Gutenberg deactivated? No; using WordPress Beta Tester plugin
Are you using a default theme (e.g. Twenty Twenty-One)? Twenty Twenty-Three
OS: macOS Monterey 12.6
Browser: tested in Chrome, Firefox and Safari

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@ndiego ndiego added [Block] Quote Affects the Quote Block [Type] Bug An existing feature does not function as intended labels Sep 30, 2022
@ndiego
Copy link
Member

ndiego commented Sep 30, 2022

I can confirm this. As the new Quote block is a primary feature of 6.1, I think we need to get this fixed before release.

@glendaviesnz glendaviesnz self-assigned this Oct 3, 2022
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Oct 3, 2022
@glendaviesnz
Copy link
Contributor

glendaviesnz commented Oct 3, 2022

This seems to fix it - it looks like __experimentalSlashInserter support was added before the v2 of the block so shouldn't be needed now.

@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Quote Affects the Quote Block [Type] Bug An existing feature does not function as intended
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants