Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popover: refactor all usages of the legacy position prop to the placement prop #44401

Open
13 of 17 tasks
Tracked by #42770
ciampo opened this issue Sep 22, 2022 · 2 comments
Open
13 of 17 tasks
Tracked by #42770
Labels
[Package] Components /packages/components [Type] Overview Comprehensive, high level view of an area of focus often with multiple tracking issues

Comments

@ciampo
Copy link
Contributor

ciampo commented Sep 22, 2022

After #40740, there are two different props in the Popover component to affect is position: position (legacy) and placement (new)

In order to deprecate the legacy position prop from the Popover component, we should first migrate all current usages to the new placement prop:

@ciampo ciampo changed the title Refactor all consumers to use the new prop Popover: refactor all usages of the legacy position prop to the placement prop Sep 22, 2022
@ciampo ciampo added the [Package] Components /packages/components label Sep 22, 2022
@jordesign jordesign added the [Type] Overview Comprehensive, high level view of an area of focus often with multiple tracking issues label Aug 3, 2023
@annezazu
Copy link
Contributor

It looks like the majority of work planned here has been completed. Closing this out as a result but happy to reopen if that's incorrect!

@ciampo
Copy link
Contributor Author

ciampo commented Jul 19, 2024

@annezazu I think the issue could still be relevant, I'd love to get to complete the missing tasks if possible. Let's keep it open for now, and see if we can get to (at least) some of those

@ciampo ciampo reopened this Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Overview Comprehensive, high level view of an area of focus often with multiple tracking issues
Projects
Status: In progress (owned) ⏳
Development

No branches or pull requests

3 participants