Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable copy/cut shortcut on the site editor #43709

Closed
t-hamano opened this issue Aug 30, 2022 · 2 comments · Fixed by #45752
Closed

Enable copy/cut shortcut on the site editor #43709

t-hamano opened this issue Aug 30, 2022 · 2 comments · Fixed by #45752
Assignees
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Package] Edit Site /packages/edit-site

Comments

@t-hamano
Copy link
Contributor

What problem does this address?

I was testing shortcuts on Windows in #43352 and found that the copy/cut shortcut doesn't work only in the site editor.
This does not seem to be an OS issue.

Personally, I feel it is very inconvenient that this shortcut is not available in the site editor.

What is your proposed solution?

Unless there is a clear reason not to opt-in to this shortcut in the site editor only, I believe the shortcut should be added like any other editor.

As a test, I merged the useClipboardHandler into the following ref, and the shortcuts seem to work on the site editor:

const mergedRefs = useMergeRefs( [ contentRef, useTypingObserver() ] );

Screencast

4b05473e82d30aedd7a0f447033c2dc4.mp4
@t-hamano t-hamano added [Package] Edit Site /packages/edit-site [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Aug 30, 2022
@t-hamano t-hamano self-assigned this Aug 30, 2022
@noisysocks
Copy link
Member

Hi @t-hamano I unassigned you as I can't see that you're working on this. Re-assign yourself if I'm mistaken 😀

@t-hamano
Copy link
Contributor Author

t-hamano commented Nov 4, 2022

@noisysocks
Sorry, I forgot to address this issue. I hope to submit a PR soon.

@t-hamano t-hamano self-assigned this Nov 4, 2022
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Nov 14, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Package] Edit Site /packages/edit-site
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants