Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disabled default color features still output as CSS variables in DOM #43385

Closed
via-lars opened this issue Aug 18, 2022 · 1 comment
Closed

disabled default color features still output as CSS variables in DOM #43385

via-lars opened this issue Aug 18, 2022 · 1 comment
Labels
[Feature] Colors Color management Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed

Comments

@via-lars
Copy link

Description

disabling color features such as default pallette by theme.json lets their values still be output in DOM by WordPress as CSS variables

Step-by-step reproduction instructions

  1.  "$schema": "https://schemas.wp.org/wp/6.0/theme.json",
     "version": 2,
     "settings": {
         "color": {
             "defaultPalette": false,
             "defaultGradients": false,
             "defaultDuotone": false
     }
     }
    

}```
2. see debugger

Screenshots, screen recording, code snippet

image

Environment info

WordPress 6.0.1

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@skorasaurus skorasaurus added [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed [Feature] Colors Color management Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Aug 18, 2022
@skorasaurus
Copy link
Member

Hi,

Thank you for your request.

The default color palette is still loaded so those variables can by other plugins in the WordPress Ecosystem (as explained at #24684 (comment))

Discussion is ongoing in #29568 and you can share your comments in there.

Regarding the removal of the duotones and gradients:
This has been requested in #38299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Colors Color management Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed
Projects
None yet
Development

No branches or pull requests

2 participants