Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global styles: Heading color options present in Button styles panel #43192

Closed
jameskoster opened this issue Aug 12, 2022 · 3 comments
Closed
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended

Comments

@jameskoster
Copy link
Contributor

If you navigate: Styles > Blocks > Button > Colors, you will see options to set the text/background color of Headings. Since you cannot place Headings inside Buttons this feels a bit out-of-place.

headings.mp4
@jameskoster jameskoster added [Type] Bug An existing feature does not function as intended Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Aug 12, 2022
@carolinan
Copy link
Contributor

It is not only on the button but on any block that has color options.

@carolinan
Copy link
Contributor

carolinan commented Sep 12, 2022

How can we improve this?
Is there a way to create an allowed list, and only include the option if the block is on that list?
And can that list be automated, so that we do not need to update it repeatedly?
Or perhaps a check if the block allows inner blocks?

@carolinan carolinan added the Needs Dev Ready for, and needs developer efforts label Sep 12, 2022
@jameskoster
Copy link
Contributor Author

This is no longer an issue :)

@carolinan carolinan removed the Needs Dev Ready for, and needs developer efforts label May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants