Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popover arrow not working properly in the latest versions #42820

Closed
renatho opened this issue Jul 29, 2022 · 2 comments · Fixed by #42874
Closed

Popover arrow not working properly in the latest versions #42820

renatho opened this issue Jul 29, 2022 · 2 comments · Fixed by #42874
Assignees
Labels
[Package] Components /packages/components [Type] Bug An existing feature does not function as intended

Comments

@renatho
Copy link
Contributor

renatho commented Jul 29, 2022

Description

Popover arrow is working well on WP 6.0, but when I activate the Gutenberg plugin (from the repository), it's not working properly anymore.

Step-by-step reproduction instructions

The way to reproduce is through code.

  1. In the editor, add a popover with the prop noArrow={true}.
  2. Open it in an env with WP 6.0 and see it working properly.
  3. Open it in an env with WP 6.0, and Gutenberg plugin (trunk) activated, and see that it doesn't work properly anymore.

Screenshots, screen recording, code snippet

Using WP 6.0 with Gutenberg plugin deactivated (working):

With Gutenberg (trunk) plugin activated (not working):

A case with Gutenberg plugin activated, with the Popover opening in the bottom (the arrow appears, but in a weird way):

Screen Shot 2022-07-29 at 10 46 23

A code snippet to test:

<Popover noArrow={ false }>
  <div style={ { width: '400px', height: '400px' } }>
    Lorem ipsum
  </div>
</Popover>

Environment info

  • WordPress 6.0 with Gutenberg plugin activated (trunk) in Chrome.

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@ciampo ciampo added [Type] Bug An existing feature does not function as intended [Package] Components /packages/components labels Jul 29, 2022
@mirka
Copy link
Member

mirka commented Aug 1, 2022

Confirmed as a regression introduced in #40740.

This is reproducing in Storybook, as well as the only place in the Gutenberg codebase where noArrow: false is used, which is the Add New Template popover in the Site Editor (go to /wp-admin/site-editor.php?postType=wp_template and click the Add New button in the top right)

Add New Template popover

Before

The popover arrow is styled correctly (white)

After

The popover arrow is styled incorrectly (grey and too small)

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Aug 1, 2022
@ciampo
Copy link
Contributor

ciampo commented Aug 1, 2022

Tentative fix opened #42874

@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants