Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation links incorrectly underlined in editor #42766

Closed
Andrew-Starr opened this issue Jul 28, 2022 · 2 comments
Closed

Navigation links incorrectly underlined in editor #42766

Andrew-Starr opened this issue Jul 28, 2022 · 2 comments
Labels
[Block] Navigation Affects the Navigation Block [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Type] Bug An existing feature does not function as intended [Type] WP Core Ticket Requires an upstream change from WordPress. Core Trac ticket should be linked.

Comments

@Andrew-Starr
Copy link

Description

In the editor, navigation links are always underlined, even when the text decoration is set to not be underlined.

In the front end all is OK. The issue is only present in the editor with Gutenberg active.
With Gutenberg inactive, all is OK.

Step-by-step reproduction instructions

  1. add a Navigation block with some menu items, or edit a post/page/template/part already containing a Navigation block.
  2. Make sure the Decoration option is not set to Underline.
  3. Notice the menu item links are always underlined.
  4. Switch to front end view and notice the links are correctly not underlined.

Screenshots, screen recording, code snippet

No response

Environment info

6.0.1 with Gutenberg 13.7.3

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@talldan talldan added Needs Testing Needs further testing to be confirmed. [Block] Navigation Affects the Navigation Block labels Aug 2, 2022
@apeatling
Copy link
Contributor

apeatling commented Aug 30, 2022

Confirmed this is an issue.

If you select the underline decoration setting, it's not possible to toggle it off again unless you remove the Decoration option and re-add it.

Edit: It looks like this is the expected behaviour, which is confusing because you'd expect to be able to toggle underline on and off in this UI. The toggle group control usage here strikes me as strange as you don't naturally think of underline/line-through options as something you toggle between.

@mrfoxtalbot
Copy link

I can confirm this is still happening (WP 6.0.3 / Plugin 14.3.1) using Twenty Twenty-Two

Screen Shot on 2022-10-25 at 10:51:01

I did a test with Twenty Twenty-Three and it seems to be working as expected there.
Screen Shot on 2022-10-25 at 10:55:03

I also tested this on other FSE themes and it works correctly on some of them ("Sparkle FSE" for instance).

Taking into account all of the above, I would say that this is a defect with Twenty Twenty-Two itself. I have moved this to Trac: https://core.trac.wordpress.org/ticket/56904

@mrfoxtalbot mrfoxtalbot added [Type] WP Core Ticket Requires an upstream change from WordPress. Core Trac ticket should be linked. [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. labels Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Type] Bug An existing feature does not function as intended [Type] WP Core Ticket Requires an upstream change from WordPress. Core Trac ticket should be linked.
Projects
None yet
Development

No branches or pull requests

4 participants