Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heading element is not included in theme.json #42313

Closed
mikachan opened this issue Jul 11, 2022 · 1 comment · Fixed by #42433
Closed

Heading element is not included in theme.json #42313

mikachan opened this issue Jul 11, 2022 · 1 comment · Fixed by #42433
Assignees
@t-hamano
Labels
Developer Experience Ideas about improving block and theme developer experience [Type] Enhancement A suggestion for improvement.

Comments

@mikachan
Copy link
Member

The heading element at styles.elements.heading has not yet been added to the theme.json schema. We should add this to provide a good developer experience.
@mikachan mikachan added the Developer Experience Ideas about improving block and theme developer experience label Jul 11, 2022
@mikachan mikachan moved this to Issues Created in Ignite Build a Theme Jul 11, 2022
@anton-vlasenko anton-vlasenko added the [Type] Enhancement A suggestion for improvement. label Jul 11, 2022
@t-hamano t-hamano mentioned this issue Jul 14, 2022
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jul 14, 2022
@t-hamano
Copy link
Contributor

Hi @mikachan,
I examined theme.json and found that the following two elements are not defined.

#42433 is the PR for the solution 👍

@mikachan mikachan moved this from Issues Created to In Progress in Ignite Build a Theme Jul 14, 2022
Repository owner moved this from In Progress to Done in Ignite Build a Theme Jul 20, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t-hamano t-hamano

Labels
Developer Experience Ideas about improving block and theme developer experience [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Theme.json: Add support for heading / caption elements in theme.json schema WordPress/gutenberg
4 participants
@mikachan @priethor @anton-vlasenko @t-hamano