Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Canvas height in focus mode should wrap document contents #42226

Closed
Tracked by #41241
jameskoster opened this issue Jul 7, 2022 · 4 comments · Fixed by #43408 or #44637
Closed
Tracked by #41241

Canvas height in focus mode should wrap document contents #42226

jameskoster opened this issue Jul 7, 2022 · 4 comments · Fixed by #43408 or #44637
Assignees
@glendaviesnz
Labels
[Feature] Focus Mode Zoomed in focus mode for editing things like template parts [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@jameskoster
Copy link
Contributor

I'm sure we discussed this elsewhere but I am struggling to find the issue. Apologies in advance if this is a duplicate.

When you enter focus mode to edit something like a header, the canvas stretches to fill the viewport. This can make it difficult to understand the boundaries of the entity you're editing:

focus.mp4

Ideally the canvas should wrap its contents more precisely, something like:

Screenshot 2022-07-07 at 12 09 08
@jameskoster jameskoster added [Type] Bug An existing feature does not function as intended [Feature] Focus Mode Zoomed in focus mode for editing things like template parts labels Jul 7, 2022
@jameskoster jameskoster mentioned this issue Jul 7, 2022
Closed
43 tasks
@Mamaduka
Copy link
Member

It was initially fixed in #37394. Leave a note for future reference.

@Mamaduka Mamaduka mentioned this issue Jul 27, 2022
Closed
@mtias mtias added the [Type] Task Issues or PRs that have been broken down into an individual action to take label Jul 27, 2022
@mtias
Copy link
Member

mtias commented Jul 27, 2022

We should prioritize this as it makes the view feel super weird and kind of pointless.

@scruffian scruffian mentioned this issue Jul 28, 2022
Open
68 tasks
@Mamaduka
Copy link
Member

Mamaduka commented Aug 2, 2022

I did git bisect and it looks like #38855 introduced the regression. After it autoResizeIframeHeight stopped working correctly.

@priethor priethor added the [Priority] High Used to indicate top priority items that need quick attention label Aug 18, 2022
@talldan talldan self-assigned this Aug 19, 2022
@talldan talldan mentioned this issue Aug 19, 2022
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Aug 19, 2022
Repository owner moved this from Triage to Done in WordPress 6.1 Editor Tasks Aug 22, 2022
@talldan
Copy link
Contributor

talldan commented Sep 21, 2022

I noticed this one is still not working perfectly. Particularly when reloading the editor while in the focus mode:

Kapture.2022-09-21.at.17.07.32.mp4

Reopening the issue.

@talldan talldan reopened this Sep 21, 2022
Repository owner moved this from Done to Triage in WordPress 6.1 Editor Tasks Sep 21, 2022
@talldan talldan removed the [Status] In Progress Tracking issues with work in progress label Sep 21, 2022
@talldan talldan removed their assignment Sep 21, 2022
@glendaviesnz glendaviesnz self-assigned this Oct 3, 2022
@glendaviesnz glendaviesnz moved this from Triage to In Progress in WordPress 6.1 Editor Tasks Oct 3, 2022
@glendaviesnz glendaviesnz mentioned this issue Oct 3, 2022
Merged
Repository owner moved this from In Progress to Done in WordPress 6.1 Editor Tasks Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glendaviesnz glendaviesnz

Labels
[Feature] Focus Mode Zoomed in focus mode for editing things like template parts [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
No open projects
WordPress 6.1 Editor Tasks
Status: Done
Milestone
No milestone
6 participants
@Mamaduka @mtias @talldan @jameskoster @glendaviesnz @priethor